From: Szabolcs Nagy <nsz@port70.net>
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux OpenRISC <linux-openrisc@vger.kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/4] openrisc: Support floating point user api
Date: Mon, 26 Jun 2023 23:38:40 +0200 [thread overview]
Message-ID: <20230626213840.GA1236108@port70.net> (raw)
In-Reply-To: <20230418165813.1900991-4-shorne@gmail.com>
* Stafford Horne <shorne@gmail.com> [2023-04-18 17:58:12 +0100]:
> Add support for handling floating point exceptions and forwarding the
> SIGFPE signal to processes. Also, add fpu state to sigcontext.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
...
> --- a/arch/openrisc/include/uapi/asm/sigcontext.h
> +++ b/arch/openrisc/include/uapi/asm/sigcontext.h
> @@ -28,6 +28,7 @@
>
> struct sigcontext {
> struct user_regs_struct regs; /* needs to be first */
> + struct __or1k_fpu_state fpu;
> unsigned long oldmask;
> };
this seems to break userspace abi.
glibc and musl have or1k abi without this field.
either this is a new abi where binaries opt-in with some marking
and then the base sigcontext should be unmodified,
or the fp state needs to be added to the signal frame in a way that
does not break existing abi (e.g. end of the struct ?) and also
advertise the new thing via a hwcap, otherwise userspace cannot
make use of it.
unless i'm missing something.
next prev parent reply other threads:[~2023-06-26 21:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 16:58 [PATCH 0/4] OpenRISC floating point context support Stafford Horne
2023-04-18 16:58 ` [PATCH 1/4] openrisc: Properly store r31 to pt_regs on unhandled exceptions Stafford Horne
2023-04-18 16:58 ` [PATCH 2/4] openrisc: Support storing and restoring fpu state Stafford Horne
2023-04-18 16:58 ` [PATCH 3/4] openrisc: Support floating point user api Stafford Horne
2023-06-26 21:38 ` Szabolcs Nagy [this message]
2023-06-27 16:41 ` Stafford Horne
2023-06-27 17:56 ` Szabolcs Nagy
2023-06-27 19:27 ` Rich Felker
2023-06-27 20:20 ` Stafford Horne
2023-07-23 21:04 ` Stafford Horne
2023-04-18 16:58 ` [PATCH 4/4] openrisc: Add floating point regset Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626213840.GA1236108@port70.net \
--to=nsz@port70.net \
--cc=Jason@zx2c4.com \
--cc=ebiederm@xmission.com \
--cc=jonas@southpole.se \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).