From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9ABC33E9 for ; Sun, 24 Apr 2022 21:52:43 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id el3so11581040edb.11 for ; Sun, 24 Apr 2022 14:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HtsX7xXS5KyrSdS4F8RNS0VhDr01GCN2iAGgDFc6qBs=; b=Bk78u/NaLlBh/+udP1b42wGjGXL+P807SEn3bt4RGvsZ6lVNKA9vUhLUIDtJu4SHO9 T9/5Z7yK5+CdL++dKToG8H03+Ijpr644TnAzeuf9hCa+Ky3DfQxmNbQ5argOSQrrIU3U GtLq73xG7eQILwhJGkUrnG9H1nHp9VbOLtGWDH+J8duVnfd4noatHsIok+vlhVQxcBwV fU1Niw1hMc/3HNwc+i2lL1L6woChrXpSTZvUa1Z58wx1w8zInanQQoj7M88+ZRlDn2Dj PAvZYWy4uvkiXgYhKbE7+XzaWRy0A+uRrdNZTwRRDs7joSr1nBCKZ/TZFLMqIaVXcRHo le3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HtsX7xXS5KyrSdS4F8RNS0VhDr01GCN2iAGgDFc6qBs=; b=7KdvTd7MkToNSxZLq+cd9E5nyHCcndg6By6gcraklsqwIOtRAdaQ6h1n3E/qxonPIh 1UsZatPrkEh6BZNk0E5tbuvv8cd9e3XKLm6UNqMfNQW1hpiXyp8JtLs1a+qg17Ag8arz IzLki4YzsGZFKmw2C2/nfm2w4QtYNqem9PHDZPX2DfLj4Z+X990FrzKoFcX5kEup/5CR y2QXtLfi/a8Oz66E8ilAi5Zi5oIKRh4Ws5+ej9qpEORGj+478iBrI/mQFIooa1yr2c48 BD08p4aAg61Fb6nJyGdycf169hvDo4Y/+I1yWAXReMH9LXrcp1lPp3ZBa9Qp9e0otGW3 IBlw== X-Gm-Message-State: AOAM533cW0xcN0roiDvsP0ZX64K6+NnaBJv3rL0+sEIbangInrvXu4dk g8To38yV5zZscarVPgwiAr2n5Q== X-Google-Smtp-Source: ABdhPJxA/GkBOyzYFPNHFGGUbgZYaFFMjxcPjHcOGJU9afJPo3NAvQlf/gAy8hcMlADO4H+DYaO7FQ== X-Received: by 2002:a05:6402:42d4:b0:416:5cac:a9a0 with SMTP id i20-20020a05640242d400b004165caca9a0mr15984539edc.86.1650837161997; Sun, 24 Apr 2022 14:52:41 -0700 (PDT) Received: from [192.168.0.117] (87-243-81-1.ip.btc-net.bg. [87.243.81.1]) by smtp.gmail.com with ESMTPSA id a94-20020a509ee7000000b00425e7035c4bsm619579edf.61.2022.04.24.14.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 14:52:41 -0700 (PDT) Message-ID: <0f1e1250-920a-c7d1-900c-98ef3e0456d8@blackwall.org> Date: Mon, 25 Apr 2022 00:52:39 +0300 Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH net-next v3 1/2] rtnetlink: add extack support in fdb del handlers Content-Language: en-US To: Alaa Mohamed , netdev@vger.kernel.org Cc: outreachy@lists.linux.dev, roopa@nvidia.com, jdenham@redhat.com, sbrivio@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, shshaikh@marvell.com, manishc@marvell.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, GR-Linux-NIC-Dev@marvell.com, bridge@lists.linux-foundation.org References: <7c8367b6-95c7-ea39-fafe-72495f343625@blackwall.org> <4bf69eef-7444-1238-0f4a-fb0fccda080c@blackwall.org> <3bcb2d3d-8b8b-8a8f-1285-7277394b4e6b@gmail.com> From: Nikolay Aleksandrov In-Reply-To: <3bcb2d3d-8b8b-8a8f-1285-7277394b4e6b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/25/22 00:09, Alaa Mohamed wrote: > > On ٢٤‏/٤‏/٢٠٢٢ ٢١:٥٥, Nikolay Aleksandrov wrote: >> On 24/04/2022 22:49, Alaa Mohamed wrote: >>> On ٢٤‏/٤‏/٢٠٢٢ ٢١:٠٢, Nikolay Aleksandrov wrote: >>>> On 24/04/2022 15:09, Alaa Mohamed wrote: >>>>> Add extack support to .ndo_fdb_del in netdevice.h and >>>>> all related methods. >>>>> >>>>> Signed-off-by: Alaa Mohamed >>>>> --- >>>>> changes in V3: >>>>>           fix errors reported by checkpatch.pl >>>>> --- >>>>>    drivers/net/ethernet/intel/ice/ice_main.c        | 4 ++-- >>>>>    drivers/net/ethernet/mscc/ocelot_net.c           | 4 ++-- >>>>>    drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 +- >>>>>    drivers/net/macvlan.c                            | 2 +- >>>>>    drivers/net/vxlan/vxlan_core.c                   | 2 +- >>>>>    include/linux/netdevice.h                        | 2 +- >>>>>    net/bridge/br_fdb.c                              | 2 +- >>>>>    net/bridge/br_private.h                          | 2 +- >>>>>    net/core/rtnetlink.c                             | 4 ++-- >>>>>    9 files changed, 12 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c >>>>> b/drivers/net/ethernet/intel/ice/ice_main.c >>>>> index d768925785ca..7b55d8d94803 100644 >>>>> --- a/drivers/net/ethernet/intel/ice/ice_main.c >>>>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c >>>>> @@ -5678,10 +5678,10 @@ ice_fdb_add(struct ndmsg *ndm, struct >>>>> nlattr __always_unused *tb[], >>>>>    static int >>>>>    ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[], >>>>>            struct net_device *dev, const unsigned char *addr, >>>>> -        __always_unused u16 vid) >>>>> +        __always_unused u16 vid, struct netlink_ext_ack *extack) >>>>>    { >>>>>        int err; >>>>> - >>>>> + >>>> What's changed here? >>> In the previous version, I removed the blank line after "int err;" >>> and you said I shouldn't so I added blank line. >>> >> Yeah, my question is are you fixing a dos ending or something else? >> The blank line is already there, what's wrong with it? > No, I didn't. >> >> The point is it's not nice to mix style fixes and other changes, more so >> if nothing is mentioned in the commit message. > Got it, So, what should I do to fix it? Don't change that line? I mean I'm even surprised this made it in the patch. As I mentioned above, there is already a new line there so I'm not sure how you're removing it and adding it again. :) Cheers, Nik