outreachy.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
To: sbrivio@redhat.com
Cc: outreachy@lists.linux.dev
Subject: [PATCH] mbuto: quote variable assignments
Date: Fri, 22 Apr 2022 11:55:59 -0400	[thread overview]
Message-ID: <20220422155559.GA356670@euclid> (raw)

Add missing quotes around variable assignments.

Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
---
 mbuto | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/mbuto b/mbuto
index 03a4547..88755c5 100755
--- a/mbuto
+++ b/mbuto
@@ -226,10 +226,10 @@ profile_kselftests() {
 	done
 	__colls="$(echo ${__colls} | ${TR} ' ' '\n' | ${SORT} -u)"
 
-	__pattern=$(list_join "${__colls}" '^' '$' '|')
+	__pattern="$(list_join "${__colls}" '^' '$' '|')"
 
-	__skip_targets=$(${AWK} '/^TARGETS/ { print $3}' ${__makefile} | \
-		${EGREP} -v "${__pattern}" | ${TR} '\n' ' ')
+	__skip_targets="$(${AWK} '/^TARGETS/ { print $3}' ${__makefile} | \
+		${EGREP} -v "${__pattern}" | ${TR} '\n' ' ')"
 
 	${MAKE} SKIP_TARGETS="${__skip_targets}" -C ${__testpath} install \
 								 >/dev/null 2>&1
@@ -240,26 +240,26 @@ profile_kselftests() {
 	INSTALL_MOD_PATH="${MODDIR}" ${MAKE} modules_install -j ${THREADS} \
 								>/dev/null
 
-	__files=$(list_join "${__colls}" "${__testpath}" '/config' ' ')
+	__files="$(list_join "${__colls}" "${__testpath}" '/config' ' ')"
 	__mods="$(${CAT} ${__files} 2>/dev/null | \
 			${AWK} -F'=' '/=m/ {print $1}' | ${SORT} -u)"
 
 	KMODS=
 	if [ ! -z "${__mods}" ]; then
-		__pattern=$(list_join "${__mods}" '^obj-\$\(' '\).*.o$' '|')
-		__result=$(${BASENAME} -a -s .o \
+		__pattern="$(list_join "${__mods}" '^obj-\$\(' '\).*.o$' '|')"
+		__result="$(${BASENAME} -a -s .o \
 			   $(${EGREP} -rn --include "*Makefile" ${__pattern} | \
-			     ${AWK} -F'+=' '/+=/ {print $2}'))
-		__find_pattern=$(list_join "${__result}" '-name ' '.ko ' '-o ')
+			     ${AWK} -F'+=' '/+=/ {print $2}'))"
+		__find_pattern="$(list_join "${__result}" '-name ' '.ko ' '-o ')"
 
-		KMODS=$(${FIND} "${MODDIR}" ${__find_pattern} | ${TR} '\n' ' ')
+		KMODS="$(${FIND} "${MODDIR}" ${__find_pattern} | ${TR} '\n' ' ')"
 
 		workers kmod_strip_worker
 
 		KMODS="$(${BASENAME} -a -s .ko ${KMODS})"
 
-		__kmods_needed=$(list_join "${__result}" '' '' ' ')
-		__kmods_missing=$(list_diff "${__kmods_needed}" "${KMODS}")
+		__kmods_needed="$(list_join "${__result}" '' '' ' ')"
+		__kmods_missing="$(list_diff "${__kmods_needed}" "${KMODS}")"
 
 		if [ ! -z "${__kmods_missing}" ]; then
 			notice "WARNING: missing modules: ${__kmods_missing}"
-- 
2.25.1


             reply	other threads:[~2022-04-22 15:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 15:55 Sevinj Aghayeva [this message]
2022-04-22 16:12 ` [PATCH] mbuto: quote variable assignments Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422155559.GA356670@euclid \
    --to=sevinj.aghayeva@gmail.com \
    --cc=outreachy@lists.linux.dev \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).