From: Sumitra Sharma <sumitraartsy@gmail.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Staging: greybus: Use inline functions
Date: Fri, 24 Mar 2023 09:19:33 -0700 [thread overview]
Message-ID: <20230324161933.GA174474@sumitra.com> (raw)
In-Reply-To: <ZB3BshO6Yen25LvB@aschofie-mobl2>
On Fri, Mar 24, 2023 at 08:28:50AM -0700, Alison Schofield wrote:
> On Fri, Mar 24, 2023 at 12:20:30AM -0700, Sumitra Sharma wrote:
> > Convert macros to a static inline function, to make the relevant
> > types apparent in the definition and to benefit from the type
> > checking performed by the compiler at call sites.
> >
> > CHanges in v2: Change patch subjects, noted by Alison Schofield
>
>
> Please review: https://kernelnewbies.org/Outreachyfirstpatch
> Section on 'Following the driver commit style'.
>
> To follow the commit style of the greybus driver, update these
> commit messages to be under 80 chars, and use "staging", not
> "Staging"
>
> Like this:
> drivers/staging/greybus$ git log --oneline | head -3
> 1498054921e2 staging: greybus: Inline pwm_chip_to_gb_pwm_chip()
> a7d2a41b7453 staging: greybus: Inline gb_audio_manager_module()
> f7d3ece211be staging: greybus: Inline macro gpio_chip_to_gb_gpio_controller()
>
> BTW - I wasn't instantly sure about using 'Inline' as a verb in this
> case, so I did this (git log --oneline | grep inline) and found it's
> a common use.
>
> We're building a habit here for when you submit across subsystems
> in the future.
>
Hi Alison,
Thank you for helping me out with this patch subject.
PS: I am focusing on writing good patch subjects and descriptions.
Regards,
Sumitra
> Alison
>
> >
> > Sumitra Sharma (3):
> > Staging: greybus: Use inline function for macro
> > gpio_chip_to_gb_gpio_controller
> > Staging: greybus: Use inline function for gb_audio_manager_module
> > Staging: greybus: Use inline function for pwm_chip_to_gb_pwm_chip
> >
> > drivers/staging/greybus/audio_manager_module.c | 7 +++++--
> > drivers/staging/greybus/gpio.c | 7 +++++--
> > drivers/staging/greybus/pwm.c | 6 ++++--
> > 3 files changed, 14 insertions(+), 6 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
prev parent reply other threads:[~2023-03-24 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 7:20 [PATCH v2 0/3] Staging: greybus: Use inline functions Sumitra Sharma
2023-03-24 7:26 ` Sumitra Sharma
2023-03-24 7:29 ` Sumitra Sharma
2023-03-24 7:29 ` [PATCH v2 1/3] Staging: greybus: Use inline function for macro gpio_chip_to_gb_gpio_controller Sumitra Sharma
2023-03-24 7:30 ` [PATCH v2 2/3] Staging: greybus: Use inline function for gb_audio_manager_module Sumitra Sharma
2023-03-24 7:30 ` [PATCH v2 3/3] Staging: greybus: Use inline function for pwm_chip_to_gb_pwm_chip Sumitra Sharma
2023-03-24 15:28 ` [PATCH v2 0/3] Staging: greybus: Use inline functions Alison Schofield
2023-03-24 16:19 ` Sumitra Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324161933.GA174474@sumitra.com \
--to=sumitraartsy@gmail.com \
--cc=alison.schofield@intel.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).