From: Ira Weiny <ira.weiny@intel.com>
To: Sumitra Sharma <sumitraartsy@gmail.com>,
Marc Dietrich <marvin24@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<ac100@lists.launchpad.net>, <linux-tegra@vger.kernel.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<outreachy@lists.linux.dev>
Subject: Re: [PATCH v4] Staging: nvec: Remove macro definition to_nvec_led
Date: Fri, 24 Mar 2023 15:10:49 -0700 [thread overview]
Message-ID: <641e1fe98339a_325e1f2941d@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20230322054051.GA150453@sumitra.com>
Sumitra Sharma wrote:
> Remove definition 'to_nvec_led' because it is only used once.
> Rewrite the code directly in the calling function
> 'nvec_led_brightness_set'.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
prev parent reply other threads:[~2023-03-24 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:40 [PATCH v4] Staging: nvec: Remove macro definition to_nvec_led Sumitra Sharma
2023-03-24 22:10 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641e1fe98339a_325e1f2941d@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=ac100@lists.launchpad.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=outreachy@lists.linux.dev \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).