From: Ira Weiny <ira.weiny@intel.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>, <outreachy@lists.linux.dev>
Cc: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
"Christian Gromm" <christian.gromm@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in video
Date: Fri, 24 Mar 2023 15:21:54 -0700 [thread overview]
Message-ID: <641e228264b79_325e1f294fc@iweiny-mobl.notmuch> (raw)
In-Reply-To: <ZBxL/yqLU1dEQlta@khadija-virtual-machine>
Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> drivers/staging/most/video/video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index ffa97ef21ea5..6254a5df2502 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
>
> /**************************************************************************/
>
> -static struct most_video_dev *get_comp_dev(
> - struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
I know the 80 char limit is not strictly enforced anymore but I, and some
other maintainers, like to see it adhered to unless there is a really good
reason to violate it. How about?
static struct most_video_dev *get_comp_dev(struct most_interface *iface,
int channel_idx)
Ira
> {
> struct most_video_dev *mdev;
> unsigned long flags;
> --
> 2.34.1
>
>
prev parent reply other threads:[~2023-03-24 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:54 [RESEND PATCH] staging: most: fix line ending with '(' in video Khadija Kamran
2023-03-23 15:04 ` Greg Kroah-Hartman
2023-03-24 22:21 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641e228264b79_325e1f294fc@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).