outreachy.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: outreachy@lists.linux.dev
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/5] staging: rtl8192e: avoid CamelCase <dot11RSNAStatsCCMPReplays>
Date: Sun,  2 Apr 2023 19:32:45 +0500	[thread overview]
Message-ID: <7166160c0face9e32dbb28c44727eb8856173f0a.1680445545.git.kamrankhadijadj@gmail.com> (raw)
In-Reply-To: <cover.1680445545.git.kamrankhadijadj@gmail.com>

Linux kernel coding-style suggests to not use mixed-case names. Fix
checkpatch issue by changing the variable name from camel case to snake
case.

Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index d37ca72678c8..448c0a931c78 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -35,7 +35,7 @@ struct rtllib_ccmp_data {
 	u8 rx_pn[CCMP_PN_LEN];
 
 	u32 dot11rsna_stats_ccmp_format_errors;
-	u32 dot11RSNAStatsCCMPReplays;
+	u32 dot11rsna_stats_ccmp_replays;
 	u32 dot11RSNAStatsCCMPDecryptErrors;
 
 	int key_idx;
@@ -263,7 +263,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 	pn[5] = pos[0];
 	pos += 8;
 	if (memcmp(pn, key->rx_pn, CCMP_PN_LEN) <= 0) {
-		key->dot11RSNAStatsCCMPReplays++;
+		key->dot11rsna_stats_ccmp_replays++;
 		return -4;
 	}
 	if (!tcb_desc->bHwSec) {
@@ -375,7 +375,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv)
 		   ccmp->key_idx, ccmp->key_set,
 		   ccmp->tx_pn, ccmp->rx_pn,
 		   ccmp->dot11rsna_stats_ccmp_format_errors,
-		   ccmp->dot11RSNAStatsCCMPReplays,
+		   ccmp->dot11rsna_stats_ccmp_replays,
 		   ccmp->dot11RSNAStatsCCMPDecryptErrors);
 }
 
-- 
2.34.1


  parent reply	other threads:[~2023-04-02 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 14:32 [PATCH v2 0/5] staging: rtl8192e: fix checkpatch issues in rtllib_crypt_ccmp.c Khadija Kamran
2023-04-02 14:32 ` [PATCH v2 1/5] staging: rtl8192e: remove extra blank lines " Khadija Kamran
2023-04-02 14:32 ` [PATCH v2 2/5] staging: rtl8192e: fix alignment to match open parenthesis Khadija Kamran
2023-04-02 14:32 ` [PATCH v2 3/5] staging: rtl8192e: avoid CamelCase <dot11RSNAStatsCCMPFormatErrors> Khadija Kamran
2023-04-02 14:32 ` Khadija Kamran [this message]
2023-04-02 14:32 ` [PATCH v2 5/5] staging: rtl8192e: avoid CamelCase <dot11RSNAStatsCCMPDecryptErrors> Khadija Kamran
2023-04-02 16:00 ` [PATCH v2 0/5] staging: rtl8192e: fix checkpatch issues in rtllib_crypt_ccmp.c Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7166160c0face9e32dbb28c44727eb8856173f0a.1680445545.git.kamrankhadijadj@gmail.com \
    --to=kamrankhadijadj@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).