From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B398C1867; Wed, 20 Apr 2022 16:33:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B218C385A1; Wed, 20 Apr 2022 16:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650472412; bh=3gwS24bB34KTAmVZROiegu+rn3qGs5bkKsOicKSeKh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i6piH7xtk3s1u5xbdcgvgatfLteKpA9aG0lQenXdczXqlblSBY1h5DpkS7EJHwuzi 9EoGKtzLb5ifOdLj/XGFALrKpGVD96byHKTStXnaN2DAbS32fYqV/HFlJAjZZeDnWw mSyo1xq5pJxz9gXlohDikrpK67osDQ6d+fjG67Ww= Date: Wed, 20 Apr 2022 18:33:29 +0200 From: Greg KH To: Jaehee Park Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Pavel Skripkin Subject: Re: [PATCH v3 1/7] staging: r8188eu: remove unused member free_bss_buf Message-ID: References: <3c5a510938ac395a13bb09c0de1868cce8ca3dd8.1650392020.git.jhpark1013@gmail.com> Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c5a510938ac395a13bb09c0de1868cce8ca3dd8.1650392020.git.jhpark1013@gmail.com> On Tue, Apr 19, 2022 at 02:19:32PM -0400, Jaehee Park wrote: > The free_bss_buf member of pmlmepriv is unused. Remove all related > lines. > > Suggested-by: Pavel Skripkin > Signed-off-by: Jaehee Park > --- > drivers/staging/r8188eu/include/rtw_mlme.h | 1 - > drivers/staging/r8188eu/core/rtw_mlme.c | 21 +-------------------- > 2 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h > index 1dc1fbf049af..0f03ac43079c 100644 > --- a/drivers/staging/r8188eu/include/rtw_mlme.h > +++ b/drivers/staging/r8188eu/include/rtw_mlme.h > @@ -319,7 +319,6 @@ struct mlme_priv { > struct list_head *pscanned; > struct __queue free_bss_pool; > struct __queue scanned_queue; > - u8 *free_bss_buf; > u8 key_mask; /* use to restore wep key after hal_init */ > u32 num_of_scanned; > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index 3e9882f89f76..8af11626a3e7 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -33,8 +33,7 @@ u8 rtw_to_roaming(struct adapter *adapter) > static int _rtw_init_mlme_priv(struct adapter *padapter) > { > int i; > - u8 *pbuf; > - struct wlan_network *pnetwork; > + struct wlan_network *pnetwork = NULL; Why did you add this line? It caused the real error to be ignored that the compiler was trying to tell you :(