From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCD19C952; Tue, 21 Mar 2023 16:21:39 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id y4so61968094edo.2; Tue, 21 Mar 2023 09:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679415698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lN54tDUmXf9hwv+PXMNCl+jsvxs7b+LzMxVySPVN8ik=; b=TP7xcMAp4UQxJz2ItJv3FiZYU+VFst7DjGgMIXfyglYpdwVEdVDe03mdwalZVRAzcJ XKpUZ1MP82LkAsPWPjKY29lBDwMQSzhIjnF7LV7TzlLXf4Ad9f/qOf/NEs1Tf7vUDBhl VNVz4ccP4nCVi+i7jH9H8m+/VTzwGF01Za/sFk7gVV8EMFc2gIi89YkGHXRdfpPxOtM5 sL9KLhhIJ8nZTPR4bys4F5iwSbmUAbEyqoI8lCbsbznO4xrtzLvd+gDp0XRI6IStzUxe yuCU1diSGOVnsU75ns8aRPohEq6t/mJQVoXmNKjDk03CYHEo6V+CHF14f9Qhu2tLrcZO hnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679415698; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lN54tDUmXf9hwv+PXMNCl+jsvxs7b+LzMxVySPVN8ik=; b=DhB+z6QtTW0WAxhwVf9o0LYg7vh9OTaSkpLB1rLZ4IKi/QgKEitN7olOHPvec9PbpH CoJz+EKJf2VcWJwmfGNghMF5Y2qTpPdX9KibdPxJ2dVFDnS9L52R+RcKWO2TQ+ERyeag daknhb5MAWhQH2D0PcpEVkiwdApGcJCm6Jn8b4GLyFV562VjbplMlzPGPoC9Zs4tytBT 2XOWeT7Lw4PKiZ0nRRBwDgA4r80bcQFFA1UexqkaQ6nKUk+uyannwI20qoTYEfRV28BJ rTvauJ5sfoT+SWMHGD1KMLFvaWimKTo+HQ2hARDXsuBFLCHWNz4viqNo8RWEv3iJg4xp d5sQ== X-Gm-Message-State: AO0yUKUwq/oUGJw5eysn2u2RaazA4dXV7WfXjlsGIxaA9V0Qelf8rx+b WErFI//LxanT5u1EPPpwOPQ= X-Google-Smtp-Source: AK7set9n+TEYOTN5JF+wpsOMVpXYpeA2AgUrMGIGu3uxrhtF1oKub2rMRl/BdhdUV2wyGEenG8Sf2A== X-Received: by 2002:a17:906:d14d:b0:931:de86:1879 with SMTP id br13-20020a170906d14d00b00931de861879mr3945437ejb.9.1679415698145; Tue, 21 Mar 2023 09:21:38 -0700 (PDT) Received: from khadija-virtual-machine ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id v19-20020a1709067d9300b008cff300cf47sm5977472ejo.72.2023.03.21.09.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 09:21:37 -0700 (PDT) Date: Tue, 21 Mar 2023 21:21:35 +0500 From: Khadija Kamran To: outreachy@lists.linux.dev Cc: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: greybus: merge split lines Message-ID: References: Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 20, 2023 at 01:26:33PM +0500, Khadija Kamran wrote: > If condition and spin_unlock_...() call is split into two lines, merge > them to form a single line. > > Suggested-by: Deepak R Varma drv@mailo.com > Signed-off-by: Khadija Kamran > --- > > Changes in v3: > - Removing tab to fix line length results in a new checkpatch warning, > so let the fix length be as it is. > Changes in v2: > - Rephrased he subject and description > - Merged if_condition() and spin_unlock...() into one line > - Link to patch: > https://lore.kernel.org/outreachy/ZAusnKYVTGvO5zoi@khadija-virtual-machine/ > > Link to first patch: > https://lore.kernel.org/outreachy/ZAtkW6g6DwPg%2FpDp@khadija-virtual-machine/ > > drivers/staging/greybus/arche-platform.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > index fcbd5f71eff2..6890710afdfc 100644 > --- a/drivers/staging/greybus/arche-platform.c > +++ b/drivers/staging/greybus/arche-platform.c > @@ -176,12 +176,10 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) > * Check we are not in middle of irq thread > * already > */ > - if (arche_pdata->wake_detect_state != > - WD_STATE_COLDBOOT_START) { > + if (arche_pdata->wake_detect_state != WD_STATE_COLDBOOT_START) { > arche_platform_set_wake_detect_state(arche_pdata, > WD_STATE_COLDBOOT_TRIG); > - spin_unlock_irqrestore(&arche_pdata->wake_lock, > - flags); > + spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); > return IRQ_WAKE_THREAD; > } > } > -- > 2.34.1 > Hey Outreachy Mentors, Kindly take a look at this patch and let me know if it is okay to work on this file or should I look for other cleanup patches. Thank you for your time. Regards, Khadija