From: David Hildenbrand <david@redhat.com>
To: Rebecca Mckeever <remckee0@gmail.com>, outreachy@lists.linux.dev
Cc: Mike Rapoport <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] memblock tests: update style of comments for memblock_reserve_*() functions
Date: Mon, 25 Apr 2022 15:39:13 +0200 [thread overview]
Message-ID: <bdbd5cb5-b480-46b9-4b81-10d2891fa7ea@redhat.com> (raw)
In-Reply-To: <7e21d96491ed573f1f7823cfe56c4d8ced4f78fe.1650633253.git.remckee0@gmail.com>
On 22.04.22 15:32, Rebecca Mckeever wrote:
> Update comments in memblock_reserve_*() functions to match the style used
> in tests/alloc_*.c by rewording to make the expected outcome more apparent
> and, if more than one memblock is involved, adding a visual of the
> memory blocks.
>
> If the comment has an extra column of spaces, remove the extra space at
> the beginning of each line for consistency and to conform to Linux kernel
> coding style.
>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-04-25 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:32 [PATCH v3 0/5] memblock tests: update style of comments Rebecca Mckeever
2022-04-22 13:32 ` [PATCH v3 1/5] memblock tests: update style of comments for memblock_add_*() functions Rebecca Mckeever
2022-04-25 13:38 ` David Hildenbrand
2022-04-22 13:32 ` [PATCH v3 2/5] memblock tests: update style of comments for memblock_reserve_*() functions Rebecca Mckeever
2022-04-25 13:39 ` David Hildenbrand [this message]
2022-04-22 13:33 ` [PATCH v3 3/5] memblock tests: update style of comments for memblock_remove_*() functions Rebecca Mckeever
2022-04-25 13:45 ` David Hildenbrand
2022-04-22 13:33 ` [PATCH v3 4/5] memblock tests: update style of comments for memblock_free_*() functions Rebecca Mckeever
2022-04-22 13:33 ` [PATCH v3 5/5] memblock tests: remove completed TODO item Rebecca Mckeever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdbd5cb5-b480-46b9-4b81-10d2891fa7ea@redhat.com \
--to=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=outreachy@lists.linux.dev \
--cc=remckee0@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).