From: Roopa Prabhu <roopa@nvidia.com>
To: Jaehee Park <jhpark1013@gmail.com>,
outreachy@lists.linux.dev, Julia Denham <jdenham@redhat.com>,
Roopa Prabhu <roopa.prabhu@gmail.com>,
Stefano Brivio <sbrivio@redhat.com>,
netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next v3] selftests: net: vrf_strict_mode_test: add support to select a test to run
Date: Thu, 28 Apr 2022 16:02:51 -0700 [thread overview]
Message-ID: <cf8ae870-8208-b4eb-fbaa-c81be95df05d@nvidia.com> (raw)
In-Reply-To: <20220428164831.GA577338@jaehee-ThinkPad-X1-Extreme>
On 4/28/22 09:48, Jaehee Park wrote:
> Add a boilerplate test loop to run all tests in
> vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to
> run.
>
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> ---
> version 3:
> - Added commented delineators to section the code for improved
> readability.
> - Moved the log_section() call into the functions handling the tests.
> - Removed unnecessary spaces.
>
>
> .../selftests/net/vrf_strict_mode_test.sh | 47 +++++++++++++++++--
> 1 file changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/net/vrf_strict_mode_test.sh b/tools/testing/selftests/net/vrf_strict_mode_test.sh
> index 865d53c1781c..423da8e08510 100755
> --- a/tools/testing/selftests/net/vrf_strict_mode_test.sh
> +++ b/tools/testing/selftests/net/vrf_strict_mode_test.sh
> @@ -14,6 +14,8 @@ INIT_NETNS_NAME="init"
>
> PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no}
>
> +TESTS="init testns mix"
> +
> log_test()
> {
> local rc=$1
> @@ -262,6 +264,8 @@ cleanup()
>
> vrf_strict_mode_tests_init()
> {
> + log_section "VRF strict_mode test on init network namespace"
> +
> vrf_strict_mode_check_support init
>
> strict_mode_check_default init
> @@ -292,6 +296,8 @@ vrf_strict_mode_tests_init()
>
> vrf_strict_mode_tests_testns()
> {
> + log_section "VRF strict_mode test on testns network namespace"
> +
> vrf_strict_mode_check_support testns
>
> strict_mode_check_default testns
> @@ -318,6 +324,8 @@ vrf_strict_mode_tests_testns()
>
> vrf_strict_mode_tests_mix()
> {
> + log_section "VRF strict_mode test mixing init and testns network namespaces"
> +
> read_strict_mode_compare_and_check init 1
>
> read_strict_mode_compare_and_check testns 0
> @@ -343,16 +351,37 @@ vrf_strict_mode_tests_mix()
>
> vrf_strict_mode_tests()
this func is no longer used correct ?, you can remove the function (that
was one of the comment from david too IIRC)
> {
> - log_section "VRF strict_mode test on init network namespace"
> vrf_strict_mode_tests_init
>
> - log_section "VRF strict_mode test on testns network namespace"
> vrf_strict_mode_tests_testns
>
> - log_section "VRF strict_mode test mixing init and testns network namespaces"
> vrf_strict_mode_tests_mix
> }
>
> +################################################################################
> +# usage
> +
> +usage()
> +{
> + cat <<EOF
> +usage: ${0##*/} OPTS
> +
> + -t <test> Test(s) to run (default: all)
> + (options: $TESTS)
> +EOF
> +}
> +
> +################################################################################
> +# main
> +
> +while getopts ":t:h" opt; do
> + case $opt in
> + t) TESTS=$OPTARG;;
> + h) usage; exit 0;;
> + *) usage; exit 1;;
> + esac
> +done
> +
> vrf_strict_mode_check_support()
> {
> local nsname=$1
> @@ -391,7 +420,17 @@ fi
> cleanup &> /dev/null
>
> setup
> -vrf_strict_mode_tests
> +for t in $TESTS
> +do
> + case $t in
> + vrf_strict_mode_tests_init|init) vrf_strict_mode_tests_init;;
> + vrf_strict_mode_tests_testns|testns) vrf_strict_mode_tests_testns;;
> + vrf_strict_mode_tests_mix|mix) vrf_strict_mode_tests_mix;;
> +
> + help) echo "Test names: $TESTS"; exit 0;;
> +
> + esac
> +done
> cleanup
>
> print_log_test_results
next prev parent reply other threads:[~2022-04-28 23:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 16:48 [PATCH net-next v3] selftests: net: vrf_strict_mode_test: add support to select a test to run Jaehee Park
2022-04-28 23:02 ` Roopa Prabhu [this message]
2022-04-29 13:34 ` Jaehee Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8ae870-8208-b4eb-fbaa-c81be95df05d@nvidia.com \
--to=roopa@nvidia.com \
--cc=dsahern@gmail.com \
--cc=jdenham@redhat.com \
--cc=jhpark1013@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=roopa.prabhu@gmail.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).