From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: outreachy@lists.linux.dev
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/4] staging: rtl8192u: clean up comments in r8192U_dm.c
Date: Tue, 28 Mar 2023 00:49:05 +0500 [thread overview]
Message-ID: <cover.1679945728.git.kamrankhadijadj@gmail.com> (raw)
Clean up several comments in file r8192U_dm.c
Changes in v3:
- Split patch 3 in two patches, one for '*' on subsequent lines and one
for '*/' on separate line, as suggested by Dan.
- Add spaces after '*' in patch 3
Changes in v2:
- Remove the 'commented code' and 'revision history' before
reformatting the block comments, as suggested by Greg. There is no use
in fixing comments, only to remove them in the next commits
- Patch 1: Changed the description and removed extra blank lines under
the change history
- Patch 2: Changed the subject and description
This patchset was created after reviewer feedback on an initial patch.
The feedback suggested additional cleanup comments. Link to the first
patch:
https://lore.kernel.org/outreachy/ZB2a5zwYpBZ%2F6qwU@khadija-virtual-machine/
Khadija Kamran (4):
staging: rtl8192u: remove change history from comments
staging: rtl8192u: remove commented out code
staging: rtl8192u: add '*' on subsequent lines in block comment
staging: rtl8192u: add '*/' on separate line in block comments
drivers/staging/rtl8192u/r8192U_dm.c | 206 +++------------------------
1 file changed, 23 insertions(+), 183 deletions(-)
--
2.34.1
next reply other threads:[~2023-03-27 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 19:49 Khadija Kamran [this message]
2023-03-27 19:49 ` [PATCH v3 1/4] staging: rtl8192u: remove change history from comments Khadija Kamran
2023-03-28 3:17 ` Bagas Sanjaya
2023-03-28 5:14 ` Julia Lawall
2023-03-27 19:49 ` [PATCH v3 2/4] staging: rtl8192u: remove commented out code Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 3/4] staging: rtl8192u: add '*' on subsequent lines in block comment Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments Khadija Kamran
2023-03-28 3:27 ` Bagas Sanjaya
2023-03-28 5:11 ` Greg KH
2023-03-28 8:48 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1679945728.git.kamrankhadijadj@gmail.com \
--to=kamrankhadijadj@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).