From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A1467C for ; Sun, 24 Apr 2022 19:20:56 +0000 (UTC) Received: by mail-wm1-f43.google.com with SMTP id f6so1729548wma.0 for ; Sun, 24 Apr 2022 12:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/+H/N/gmFAaOe4y0s+SRcJl0SyQ/fuybtesfMfHNNuQ=; b=L9/LRThN/qmaxvltFgT3Vsp3alFuHmSCHX8niKbw5nVt0f+GrPKdM+saUo8/tdJ5DH m0AMCUG97D2qOpTUIUhPAB1LV2EacwAKSkyzmxv7BAnp+FzQ0W1Dfp7aQ6g2Ix+jAcBX 35TfCkIhfMG+4YHd7moTBuvU6uDfQXEaYt4XDpjRLD5/WLBjvosQIWGdQADpLpI+nMsN 0Mxumf9sFHFtGBjiLKgIKfaXSlO28LuwSn0ICnECFbMeLP+6QU8d+Lj3jo5i/imkxMNP wZTeV39Gk0h/+2Jmf/KEcMr76MLwIWnpqzdk9D175he7a8eCIkDfw/iAcNcHdeLa3fz7 18ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/+H/N/gmFAaOe4y0s+SRcJl0SyQ/fuybtesfMfHNNuQ=; b=McOgi+SlZX6ecv9KMk2xoxQfn/ifopBD8zo7qyySJdFUF6h1ay7rHRQ8rJnFhzUmJw OB3xZ+Nlh3DDMZ/rJ15PheCk2FYiO+NsiJuh9FO2GdAEPUvCQTl2WBK79VBIUmmSCqeF F5fn/E9Q6x6a3cBx3EE1RrynF8hq7EuAuk3tedNyu9M6K/rvNnXemRe48HcFPusZ70Qf 1LmekvWBk9bZo4pMMTtUqo/z39nnnUlWZd7tnID3i9oOEHRN9B26UEob62MCghsapyRM YxGNuOs7xY15EEcyoNTaIfyt5QzUaeJJXkjck9uMOH59L+HbJHdfk5N1JbtPlcoBlJrl OENQ== X-Gm-Message-State: AOAM532bRePSSZt8PEvVrznnfIPTLV+GgX8mzRzFhEwwYJHnsljBEp9+ Ngmej0PLa2DL/gXQQ31VOCs= X-Google-Smtp-Source: ABdhPJyJ0RyDxNnhvav9Kr/ikInuVtAqUw64NFwOimQaTTCJHXwbyerv07oScutZL2Cky6iqy/leEg== X-Received: by 2002:a1c:7415:0:b0:38e:bbbf:52d9 with SMTP id p21-20020a1c7415000000b0038ebbbf52d9mr22683155wmc.104.1650828054882; Sun, 24 Apr 2022 12:20:54 -0700 (PDT) Received: from [192.168.1.5] ([197.57.78.84]) by smtp.gmail.com with ESMTPSA id e4-20020a5d6d04000000b0020a8bbbb72bsm8511452wrq.97.2022.04.24.12.20.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 12:20:54 -0700 (PDT) Message-ID: Date: Sun, 24 Apr 2022 21:20:51 +0200 Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH net-next v3 2/2] net: vxlan: vxlan_core.c: Add extack support to vxlan_fdb_delete Content-Language: en-US To: Nikolay Aleksandrov , Julia Lawall Cc: netdev@vger.kernel.org, outreachy@lists.linux.dev, roopa@nvidia.com, jdenham@redhat.com, sbrivio@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, shshaikh@marvell.com, manishc@marvell.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, GR-Linux-NIC-Dev@marvell.com, bridge@lists.linux-foundation.org References: <0d09ad611bb78b9113491007955f2211f3a06e82.1650800975.git.eng.alaamohamedsoliman.am@gmail.com> <06622e4c-b9a5-1c4f-2764-a72733000b4e@gmail.com> <3b8c790d-9e90-d920-9580-8e736435f7f3@blackwall.org> From: Alaa Mohamed In-Reply-To: <3b8c790d-9e90-d920-9580-8e736435f7f3@blackwall.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On ٢٤‏/٤‏/٢٠٢٢ ٢١:٠٣, Nikolay Aleksandrov wrote: > On 24/04/2022 21:52, Alaa Mohamed wrote: >> On ٢٤‏/٤‏/٢٠٢٢ ١٨:١٥, Julia Lawall wrote: >>> On Sun, 24 Apr 2022, Alaa Mohamed wrote: >>> >>>> Add extack to vxlan_fdb_delete and vxlan_fdb_parse >>> It could be helpful to say more about what adding extack support involves. >>> >>>> Signed-off-by: Alaa Mohamed >>>> --- >>>> changes in V2: >>>>     - fix spelling vxlan_fdb_delete >>>>     - add missing braces >>>>     - edit error message >>>> --- >>>> changes in V3: >>>>     fix errors reported by checkpatch.pl >>> But your changes would seem to also be introducing more checkpatch errors, >>> because the Linux kernel coding style puts a space before an { at the >>> start of an if branch. >> I ran checkpatch script before submitting this patch and got no error > This is what I got: > WARNING: suspect code indent for conditional statements (8, 24) > #366: FILE: drivers/net/vxlan/vxlan_core.c:1137: > if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] || > [...] > + NL_SET_ERR_MSG(extack, "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); > > WARNING: line length of 111 exceeds 100 columns > #370: FILE: drivers/net/vxlan/vxlan_core.c:1139: > + NL_SET_ERR_MSG(extack, "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); > > ERROR: space required before the open brace '{' > #377: FILE: drivers/net/vxlan/vxlan_core.c:1145: > + if (err){ > > ERROR: space required before the open brace '{' > #389: FILE: drivers/net/vxlan/vxlan_core.c:1164: > + if (nla_len(tb[NDA_PORT]) != sizeof(__be16)){ > > ERROR: space required before the open brace '{' > #400: FILE: drivers/net/vxlan/vxlan_core.c:1174: > + if (nla_len(tb[NDA_VNI]) != sizeof(u32)){ > > ERROR: space required before the open brace '{' > #411: FILE: drivers/net/vxlan/vxlan_core.c:1184: > + if (nla_len(tb[NDA_SRC_VNI]) != sizeof(u32)){ > > ERROR: space required before the open brace '{' > #423: FILE: drivers/net/vxlan/vxlan_core.c:1196: > + if (nla_len(tb[NDA_IFINDEX]) != sizeof(u32)){ > > ERROR: space required before the open brace '{' > #430: FILE: drivers/net/vxlan/vxlan_core.c:1202: > + if (!tdev){ > > ERROR: space required after that ',' (ctx:VxV) > #431: FILE: drivers/net/vxlan/vxlan_core.c:1203: > + NL_SET_ERR_MSG(extack,"Device not found"); > > Thank you for sending that , but I don't know why I missed that when I ran the script. Anyway, I fixed all these errors as Julia said. Thanks again, Alaa