[v3,0/6] Add CascadeLake-N Support
mbox series

Message ID 20191007193100.36934-1-srinivas.pandruvada@linux.intel.com
Headers show
Series
  • Add CascadeLake-N Support
Related show

Message

Srinivas Pandruvada Oct. 7, 2019, 7:30 p.m. UTC
Add support for SST-BF on CascadeLake-N support.  The CascadeLake-N
processor only support SST-BF and not other SST functionality.

v3:
Fix crash due to geline
Fix display to perf-profile info and base-freq info command
Fix output for coremask
Fix base frequency CPU list. This should be displayed for a package
Auto mode support for base-freq enable/disable
One of the patch for config only change folded to next one where it is
used.

The patch 1 has nothing to do with the CLX-N. It saves some bytes in the
size.

v2: Updated with comments from Srinivas (use common clx_n_* function names,
common is_clx_n_platform() function call to identify CascadeLake-N)


Prarit Bhargava (6):
  tools/power/x86/intel-speed-select: Add int argument to command
    functions
  tools/power/x86/intel-speed-select: Make process_command generic
  tools/power/x86/intel-speed-select: Add check for CascadeLake-N models
  tools/power/x86/intel-speed-select: Implement CascadeLake-N help and
    command functions structures
  tools/power/x86/intel-speed-select: Implement 'perf-profile info' on
    CascadeLake-N
  tools/power/x86/intel-speed-select: Implement base-freq commands on
    CascadeLake-N

 .../x86/intel-speed-select/isst-config.c      | 523 ++++++++++++------
 .../x86/intel-speed-select/isst-display.c     |  14 +-
 tools/power/x86/intel-speed-select/isst.h     |   3 +
 3 files changed, 383 insertions(+), 157 deletions(-)

Comments

Prarit Bhargava Oct. 14, 2019, 1:15 p.m. UTC | #1
On 10/7/19 3:30 PM, Srinivas Pandruvada wrote:
> Add support for SST-BF on CascadeLake-N support.  The CascadeLake-N
> processor only support SST-BF and not other SST functionality.
>

Sorry Srinivas, was away from keyboard all last week :(

> v3:
> Fix crash due to geline

^^^ curious how you hit this?  I was repeatedly testing and couldn't
get it to happen.

> Fix display to perf-profile info and base-freq info command
> Fix output for coremask
> Fix base frequency CPU list. This should be displayed for a package
> Auto mode support for base-freq enable/disable
> One of the patch for config only change folded to next one where it is
> used.
>
> The patch 1 has nothing to do with the CLX-N. It saves some bytes in the
> size.
>

Reviewed-by: Prarit Bhargava <prarit@redhat.com>

P.
Srinivas Pandruvada Oct. 14, 2019, 4:47 p.m. UTC | #2
On Mon, 2019-10-14 at 09:15 -0400, Prarit Bhargava wrote:
> 
> On 10/7/19 3:30 PM, Srinivas Pandruvada wrote:
> > Add support for SST-BF on CascadeLake-N support.  The CascadeLake-N
> > processor only support SST-BF and not other SST functionality.
> > 
> 
> Sorry Srinivas, was away from keyboard all last week :(
> 
> > v3:
> > Fix crash due to geline
> 
> ^^^ curious how you hit this?  I was repeatedly testing and couldn't
> get it to happen.
I guess this depend on weather the local variable happen to be NULL.
This happens 100% on the system I am testing.

Thanks,
Srinivas

> 
> > Fix display to perf-profile info and base-freq info command
> > Fix output for coremask
> > Fix base frequency CPU list. This should be displayed for a package
> > Auto mode support for base-freq enable/disable
> > One of the patch for config only change folded to next one where it
> > is
> > used.
> > 
> > The patch 1 has nothing to do with the CLX-N. It saves some bytes
> > in the
> > size.
> > 
> 
> Reviewed-by: Prarit Bhargava <prarit@redhat.com>
> 
> P.