[v3,00/14,RESEND] irqchip: Fix potential resource leaks
mbox series

Message ID 1592984711-3130-1-git-send-email-yangtiezhu@loongson.cn
Headers show
Series
  • irqchip: Fix potential resource leaks
Related show

Message

Tiezhu Yang June 24, 2020, 7:44 a.m. UTC
[git send-email failed due to too many commands,
 so only cc the major related email and resend it,
 sorry for that]

When I test the irqchip code of Loongson, I read the related code of other
chips in drivers/irqchip and I find some potential resource leaks in the
error path, I think it is better to fix them.

v2:
  - Split the first patch into a new patch series which
    includes small patches and add "Fixes" tag
  - Use "goto" label to handle error path in some patches

v3:
  - Add missed variable "ret" in the patch #5 and #13,
    sorry for that

Tiezhu Yang (14):
  irqchip/ath79-misc: Fix potential resource leaks
  irqchip/csky-apb-intc: Fix potential resource leaks
  irqchip/csky-mpintc: Fix potential resource leaks
  irqchip/davinci-aintc: Fix potential resource leaks
  irqchip/davinci-cp-intc: Fix potential resource leaks
  irqchip/digicolor: Fix potential resource leaks
  irqchip/dw-apb-ictl: Fix potential resource leaks
  irqchip/ls1x: Fix potential resource leaks
  irqchip/mscc-ocelot: Fix potential resource leaks
  irqchip/nvic: Fix potential resource leaks
  irqchip/omap-intc: Fix potential resource leak
  irqchip/riscv-intc: Fix potential resource leak
  irqchip/s3c24xx: Fix potential resource leaks
  irqchip/xilinx-intc: Fix potential resource leak

 drivers/irqchip/irq-ath79-misc.c      | 14 +++++++++++---
 drivers/irqchip/irq-csky-apb-intc.c   | 12 ++++++++++--
 drivers/irqchip/irq-csky-mpintc.c     | 26 ++++++++++++++++++++------
 drivers/irqchip/irq-davinci-aintc.c   | 17 +++++++++++++----
 drivers/irqchip/irq-davinci-cp-intc.c | 18 +++++++++++++++---
 drivers/irqchip/irq-digicolor.c       | 14 +++++++++++---
 drivers/irqchip/irq-dw-apb-ictl.c     | 11 ++++++++---
 drivers/irqchip/irq-ls1x.c            |  4 +++-
 drivers/irqchip/irq-mscc-ocelot.c     |  6 ++++--
 drivers/irqchip/irq-nvic.c            | 12 +++++++++---
 drivers/irqchip/irq-omap-intc.c       |  4 +++-
 drivers/irqchip/irq-riscv-intc.c      |  1 +
 drivers/irqchip/irq-s3c24xx.c         | 23 +++++++++++++++++------
 drivers/irqchip/irq-xilinx-intc.c     |  4 +++-
 14 files changed, 128 insertions(+), 38 deletions(-)

Comments

Marc Zyngier June 24, 2020, 8:30 a.m. UTC | #1
On 2020-06-24 08:44, Tiezhu Yang wrote:
> [git send-email failed due to too many commands,
>  so only cc the major related email and resend it,
>  sorry for that]

This is becoming majorly annoying. Please fix your git setup
*before* dumping 57 emails for just 14 patches. You have done
the same thing yesterday, and I would hope you learned from your
mistakes.

Also, do not repost a series more than once per week. You have
already exceeded your quota by quite a margin.

         M.
Tiezhu Yang June 24, 2020, 9:02 a.m. UTC | #2
On 06/24/2020 04:30 PM, Marc Zyngier wrote:
> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> [git send-email failed due to too many commands,
>>  so only cc the major related email and resend it,
>>  sorry for that]
>
> This is becoming majorly annoying. Please fix your git setup
> *before* dumping 57 emails for just 14 patches. You have done
> the same thing yesterday, and I would hope you learned from your
> mistakes.
>
> Also, do not repost a series more than once per week. You have
> already exceeded your quota by quite a margin.

I am very sorry for that.
I will wait for some days to resend this patch series.

>
>         M.
Tiezhu Yang June 24, 2020, 11:48 a.m. UTC | #3
On 06/24/2020 05:02 PM, Tiezhu Yang wrote:
> On 06/24/2020 04:30 PM, Marc Zyngier wrote:
>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>>> [git send-email failed due to too many commands,
>>>  so only cc the major related email and resend it,
>>>  sorry for that]
>>
>> This is becoming majorly annoying. Please fix your git setup
>> *before* dumping 57 emails for just 14 patches. You have done
>> the same thing yesterday, and I would hope you learned from your
>> mistakes.
>>
>> Also, do not repost a series more than once per week. You have
>> already exceeded your quota by quite a margin.
>
> I am very sorry for that.
> I will wait for some days to resend this patch series.

Hi Marc,

Since each patch of this series is independent, in order to avoid
git send-email failed, I prefer to resend each patch individually
and cc more related maintainer or supporter to review.

If you do not mind, I will resend each patch individually next week.
Sorry for the noisy and inconvenience.

>
>>
>>         M.
Marc Zyngier June 24, 2020, 11:52 a.m. UTC | #4
On 2020-06-24 12:48, Tiezhu Yang wrote:
> On 06/24/2020 05:02 PM, Tiezhu Yang wrote:
>> On 06/24/2020 04:30 PM, Marc Zyngier wrote:
>>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>>>> [git send-email failed due to too many commands,
>>>>  so only cc the major related email and resend it,
>>>>  sorry for that]
>>> 
>>> This is becoming majorly annoying. Please fix your git setup
>>> *before* dumping 57 emails for just 14 patches. You have done
>>> the same thing yesterday, and I would hope you learned from your
>>> mistakes.
>>> 
>>> Also, do not repost a series more than once per week. You have
>>> already exceeded your quota by quite a margin.
>> 
>> I am very sorry for that.
>> I will wait for some days to resend this patch series.
> 
> Hi Marc,
> 
> Since each patch of this series is independent, in order to avoid
> git send-email failed, I prefer to resend each patch individually
> and cc more related maintainer or supporter to review.

Don't do that. Just fix your GIT setup.

> If you do not mind, I will resend each patch individually next week.
> Sorry for the noisy and inconvenience.

They are perfectly fine as a series. As the person that will ultimately
merge these patches, I don't want to go and fish individual patches,
which is the best way to miss some.

         M.
Aleksandar Markovic June 28, 2020, 11:25 a.m. UTC | #5
сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-24 08:44, Tiezhu Yang wrote:
> > [git send-email failed due to too many commands,
> >  so only cc the major related email and resend it,
> >  sorry for that]
>
> This is becoming majorly annoying.

I don't think this is the right vocabulary to welcome newcomers,
however "terrible" thinks they did.

Rather, patience, calmness and clear and detailed explanations would
work much better - and certainly be much more helpful and useful to
the community in the long run.

Regards,
Aleksandar

> Please fix your git setup
> *before* dumping 57 emails for just 14 patches. You have done
> the same thing yesterday, and I would hope you learned from your
> mistakes.
>
> Also, do not repost a series more than once per week. You have
> already exceeded your quota by quite a margin.
>
>          M.
> --
> Jazz is not dead. It just smells funny...
Marc Zyngier June 28, 2020, 12:06 p.m. UTC | #6
On 2020-06-28 12:25, Aleksandar Markovic wrote:
> сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>> 
>> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> > [git send-email failed due to too many commands,
>> >  so only cc the major related email and resend it,
>> >  sorry for that]
>> 
>> This is becoming majorly annoying.
> 
> I don't think this is the right vocabulary to welcome newcomers,
> however "terrible" thinks they did.
> 
> Rather, patience, calmness and clear and detailed explanations would
> work much better - and certainly be much more helpful and useful to
> the community in the long run.

Pray tell how you would have handled this. I expressed *my* personal
frustration at a SNR hovering below the 25% mark. I have only indicated
that the current course of action was becoming a problem.

And instead of taking the moral high ground, maybe you could actually
share your wisdom with Teizhu and help him becoming a better 
contributor?

Thanks,

         M.
Aleksandar Markovic June 28, 2020, 12:48 p.m. UTC | #7
нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-28 12:25, Aleksandar Markovic wrote:
> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
> >>
> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
> >> > [git send-email failed due to too many commands,
> >> >  so only cc the major related email and resend it,
> >> >  sorry for that]
> >>
> >> This is becoming majorly annoying.
> >
> > I don't think this is the right vocabulary to welcome newcomers,
> > however "terrible" thinks they did.
> >
> > Rather, patience, calmness and clear and detailed explanations would
> > work much better - and certainly be much more helpful and useful to
> > the community in the long run.
>
> Pray tell how you would have handled this. I expressed *my* personal
> frustration at a SNR hovering below the 25% mark. I have only indicated
> that the current course of action was becoming a problem.
>
> And instead of taking the moral high ground, maybe you could actually
> share your wisdom with Teizhu and help him becoming a better
> contributor?
>

He will improve. This initial clumsiness is normal. It could have been
avoided, true - for example, if he had had someone more experienced at
hand, preferably a co-worker. He obviously acts alone. It will be
better.

> Thanks,
>
>          M.
> --
> Jazz is not dead. It just smells funny...
Marc Zyngier June 28, 2020, 4:55 p.m. UTC | #8
On 2020-06-28 13:48, Aleksandar Markovic wrote:
> нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
>> 
>> On 2020-06-28 12:25, Aleksandar Markovic wrote:
>> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
>> >>
>> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
>> >> > [git send-email failed due to too many commands,
>> >> >  so only cc the major related email and resend it,
>> >> >  sorry for that]
>> >>
>> >> This is becoming majorly annoying.
>> >
>> > I don't think this is the right vocabulary to welcome newcomers,
>> > however "terrible" thinks they did.
>> >
>> > Rather, patience, calmness and clear and detailed explanations would
>> > work much better - and certainly be much more helpful and useful to
>> > the community in the long run.
>> 
>> Pray tell how you would have handled this. I expressed *my* personal
>> frustration at a SNR hovering below the 25% mark. I have only 
>> indicated
>> that the current course of action was becoming a problem.
>> 
>> And instead of taking the moral high ground, maybe you could actually
>> share your wisdom with Teizhu and help him becoming a better
>> contributor?
>> 
> 
> He will improve. This initial clumsiness is normal. It could have been
> avoided, true - for example, if he had had someone more experienced at
> hand, preferably a co-worker. He obviously acts alone. It will be
> better.

I thank you for imparting your insight on us. You clearly have helped
things moving forward, and I am sure Teizhu now knows a lot more about
what he should have done.

         M.
Aleksandar Markovic June 28, 2020, 5 p.m. UTC | #9
нед, 28. јун 2020. у 18:55 Marc Zyngier <maz@kernel.org> је написао/ла:
>
> On 2020-06-28 13:48, Aleksandar Markovic wrote:
> > нед, 28. јун 2020. у 14:06 Marc Zyngier <maz@kernel.org> је написао/ла:
> >>
> >> On 2020-06-28 12:25, Aleksandar Markovic wrote:
> >> > сре, 24. јун 2020. у 10:40 Marc Zyngier <maz@kernel.org> је написао/ла:
> >> >>
> >> >> On 2020-06-24 08:44, Tiezhu Yang wrote:
> >> >> > [git send-email failed due to too many commands,
> >> >> >  so only cc the major related email and resend it,
> >> >> >  sorry for that]
> >> >>
> >> >> This is becoming majorly annoying.
> >> >
> >> > I don't think this is the right vocabulary to welcome newcomers,
> >> > however "terrible" thinks they did.
> >> >
> >> > Rather, patience, calmness and clear and detailed explanations would
> >> > work much better - and certainly be much more helpful and useful to
> >> > the community in the long run.
> >>
> >> Pray tell how you would have handled this. I expressed *my* personal
> >> frustration at a SNR hovering below the 25% mark. I have only
> >> indicated
> >> that the current course of action was becoming a problem.
> >>
> >> And instead of taking the moral high ground, maybe you could actually
> >> share your wisdom with Teizhu and help him becoming a better
> >> contributor?
> >>
> >
> > He will improve. This initial clumsiness is normal. It could have been
> > avoided, true - for example, if he had had someone more experienced at
> > hand, preferably a co-worker. He obviously acts alone. It will be
> > better.
>
> I thank you for imparting your insight on us. You clearly have helped
> things moving forward, and I am sure Teizhu now knows a lot more about
> what he should have done.
>

Irony and arrogance are certainly not the things that would attract
future contributors. I think that is a real new insight - for you.

Regards,
Aleksandar

>          M.
> --
> Jazz is not dead. It just smells funny...