[v3,0/2] phy: ralink: phy-mt7621-pci: some fixes for COMPILE_TEST
mbox series

Message ID 20201201112051.17463-1-sergio.paracuellos@gmail.com
Headers show
Series
  • phy: ralink: phy-mt7621-pci: some fixes for COMPILE_TEST
Related show

Message

Sergio Paracuellos Dec. 1, 2020, 11:20 a.m. UTC
Hi Vinod,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
17 | #include <mt7621.h>
 |          ^~~~~~~~~~

This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h

This is because this path is directly included in 'arch/mips/ralink/Platform'
for "ralink".

Adding the include search path to the phy ralink directory fix the problem but
as you told me I finally end up removing COMPILE_TEST from Kconfig.

Making 'allmodconfig' in x86_64 also showed two warnings for this driver
because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.

Ids for the macro has been also included in this series.

Changes in v3:
    - PATCH 1/3 completely changed:
        - Makefile is not touched.
        - Drop 'COMPILE_TEST' in Kconfig.
    - Drop PATCH 2/3 in previous series because COMPILE_TEST does not apply anymore.

Changes in v2:
    - Added 'Reported-by' tag in PATCH 1/3.

Best regards,
    Sergio Paracuellos

Sergio Paracuellos (2):
  phy: ralink: phy-mt7621-pci: drop 'COMPILE_TEST' from Kconfig
  phy: ralink: phy-mt7621-pci: set correct name in MODULE_DEVICE_TABLE
    macro

 drivers/phy/ralink/Kconfig          | 2 +-
 drivers/phy/ralink/phy-mt7621-pci.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Vinod Koul Dec. 1, 2020, 11:44 a.m. UTC | #1
On 01-12-20, 12:20, Sergio Paracuellos wrote:
> Hi Vinod,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> 17 | #include <mt7621.h>
>  |          ^~~~~~~~~~
> 
> This driver has two includes which are in
> "arch/mips/include/asm/mach-ralink" and are directly included in the
> driver:
> * mt7621.h
> * ralink_regs.h
> 
> This is because this path is directly included in 'arch/mips/ralink/Platform'
> for "ralink".
> 
> Adding the include search path to the phy ralink directory fix the problem but
> as you told me I finally end up removing COMPILE_TEST from Kconfig.
> 
> Making 'allmodconfig' in x86_64 also showed two warnings for this driver
> because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
> 
> Ids for the macro has been also included in this series.

Applied, thanks
Sergio Paracuellos Dec. 1, 2020, 11:57 a.m. UTC | #2
On Tue, Dec 1, 2020 at 12:44 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 01-12-20, 12:20, Sergio Paracuellos wrote:
> > Hi Vinod,
> >
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> > 17 | #include <mt7621.h>
> >  |          ^~~~~~~~~~
> >
> > This driver has two includes which are in
> > "arch/mips/include/asm/mach-ralink" and are directly included in the
> > driver:
> > * mt7621.h
> > * ralink_regs.h
> >
> > This is because this path is directly included in 'arch/mips/ralink/Platform'
> > for "ralink".
> >
> > Adding the include search path to the phy ralink directory fix the problem but
> > as you told me I finally end up removing COMPILE_TEST from Kconfig.
> >
> > Making 'allmodconfig' in x86_64 also showed two warnings for this driver
> > because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
> >
> > Ids for the macro has been also included in this series.
>
> Applied, thanks
>

Thanks for letting me know.

Best regards,
    Sergio Paracuellos
> --
> ~Vinod