[RFT,v1,0/3] ACPI: scan: Defer enumeration of devices with significant dependencies
mbox series

Message ID 1646930.v2jOOB1UEN@kreacher
Headers show
Series
  • ACPI: scan: Defer enumeration of devices with significant dependencies
Related show

Message

Rafael J. Wysocki Dec. 14, 2020, 8:23 p.m. UTC
Hi,

This series addresses some enumeration ordering issues by using information
from _DEP to defer the enumeration of devices that are likely to depend on
operation region (OpRegion) handlers supplied by the drivers of other
devices.

This allows the OpRegion suppliers to be probed and start working before the
devices depending on them are enumerated.

Please see the patch changelogs for details.

Hans, please test this series on the system with OpRegion dependencies in
control methods used for device enumeration.

Thanks!

Comments

Hans de Goede Dec. 15, 2020, 11:17 a.m. UTC | #1
Hi,

On 12/14/20 9:23 PM, Rafael J. Wysocki wrote:
> Hi,
> 
> This series addresses some enumeration ordering issues by using information
> from _DEP to defer the enumeration of devices that are likely to depend on
> operation region (OpRegion) handlers supplied by the drivers of other
> devices.
> 
> This allows the OpRegion suppliers to be probed and start working before the
> devices depending on them are enumerated.
> 
> Please see the patch changelogs for details.
> 
> Hans, please test this series on the system with OpRegion dependencies in
> control methods used for device enumeration.

Thank you for you work on this!

I started with reviewing the series so that I would know what to
expect during testing. All 3 patches look good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

As is the series does not fix the Bluetooth HID misreporting on
the system with OpRegion dependencies in its BT ACPI node's _HID,
but ...

This is expected because that _HID has a _DEP on the GPO1 GPIO
controller, which in turn has a _DEP pointing to the
"Intel Baytrail Mailbox Device" ("INT33BD")

We (Linux) don't do anything with the INT33BD device, so it can
simply be added to the acpi_ignore_dep_ids list. With this done the
3 patches from this RFT fix the BT _HID issue. IOW everything works
as expected / as we want.

While at it I also booted the kernel with these patches on a
Lenovo Yoga X1 Carbon 8th gen. I'm not seeing any adverse side
effects there, so please add my tested-by to the entire series:

Tested-by: Hans de Goede <hdegoede@redhat.com>

I will send out a patch adding "INT33BD" to the
acpi_ignore_dep_ids list (to be applied on top of this series)
right away.

Regards,

Hans
Mika Westerberg Dec. 17, 2020, 9:27 a.m. UTC | #2
Hi Rafael,

On Mon, Dec 14, 2020 at 09:23:47PM +0100, Rafael J. Wysocki wrote:
> Hi,
> 
> This series addresses some enumeration ordering issues by using information
> from _DEP to defer the enumeration of devices that are likely to depend on
> operation region (OpRegion) handlers supplied by the drivers of other
> devices.
> 
> This allows the OpRegion suppliers to be probed and start working before the
> devices depending on them are enumerated.

For the whole series,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>