[0/4] spi: Adding support for software nodes
mbox series

Message ID 20210303152814.35070-1-heikki.krogerus@linux.intel.com
Headers show
Series
  • spi: Adding support for software nodes
Related show

Message

Heikki Krogerus March 3, 2021, 3:28 p.m. UTC
Hi,

The older API used to supply additional device properties for the
devices - so mainly the function device_add_properties() - is going to
be removed. The reason why the API will be removed is because it gives
false impression that the properties are assigned directly to the
devices, which has actually never been the case - the properties have
always been assigned to a software fwnode which was then just directly
linked with the device when the old API was used. By only accepting
device properties instead of complete software nodes, the subsystems
remove any change of taking advantage of the other features the
software nodes have.

The change that is required from the spi subsystem and the drivers is
trivial. Basically only the "properties" member in struct
spi_board_info, which was a pointer to struct property_entry, is
replaced with a pointer to a complete software node.

thanks,

Heikki Krogerus (4):
  spi: Add support for software nodes
  ARM: pxa: icontrol: Constify the software node
  ARM: pxa: zeus: Constify the software node
  spi: Remove support for dangling device properties

 arch/arm/mach-pxa/icontrol.c | 12 ++++++++----
 arch/arm/mach-pxa/zeus.c     |  6 +++++-
 drivers/spi/spi.c            | 21 ++++++---------------
 include/linux/spi/spi.h      |  7 +++----
 4 files changed, 22 insertions(+), 24 deletions(-)

Comments

Mark Brown March 12, 2021, 8:47 p.m. UTC | #1
On Wed, Mar 03, 2021 at 06:28:10PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> The older API used to supply additional device properties for the
> devices - so mainly the function device_add_properties() - is going to
> be removed. The reason why the API will be removed is because it gives

This makes sense to me, OK to apply the PXA patches via the SPI tree?
Mark Brown March 16, 2021, 5:59 p.m. UTC | #2
On Wed, 3 Mar 2021 18:28:10 +0300, Heikki Krogerus wrote:
> The older API used to supply additional device properties for the
> devices - so mainly the function device_add_properties() - is going to
> be removed. The reason why the API will be removed is because it gives
> false impression that the properties are assigned directly to the
> devices, which has actually never been the case - the properties have
> always been assigned to a software fwnode which was then just directly
> linked with the device when the old API was used. By only accepting
> device properties instead of complete software nodes, the subsystems
> remove any change of taking advantage of the other features the
> software nodes have.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/4] spi: Add support for software nodes
      commit: 47afc77bbfeac163d81c7a675d608c18561aa680
[2/4] ARM: pxa: icontrol: Constify the software node
      commit: 2df0c4a640c55c0eff7f97907b98ad6fdfedd226
[3/4] ARM: pxa: zeus: Constify the software node
      commit: d4272a7adf26c62c5afe86b6829712de519b4a26
[4/4] spi: Remove support for dangling device properties
      commit: df41a5dad586c8ead1bb7082b4b6fcb563e02199

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark