From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: [PATCH] m68k: remove redundant 'default n' from Kconfig
Date: Tue, 16 Oct 2018 15:33:58 +0200 [thread overview]
Message-ID: <20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f~eGh5UqXXL3084730847eucas1p2h@eucas1p2.samsung.com> (raw)
In-Reply-To: CGME20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f@eucas1p2.samsung.com
'default n' is the default value for any bool or tristate Kconfig
setting so there is no need to write it explicitly.
Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
is not set' for visible symbols") the Kconfig behavior is the same
regardless of 'default n' being present or not:
...
One side effect of (and the main motivation for) this change is making
the following two definitions behave exactly the same:
config FOO
bool
config FOO
bool
default n
With this change, neither of these will generate a
'# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
That might make it clearer to people that a bare 'default n' is
redundant.
...
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
arch/m68k/Kconfig.machine | 2 --
1 file changed, 2 deletions(-)
Index: b/arch/m68k/Kconfig.machine
===================================================================
--- a/arch/m68k/Kconfig.machine 2018-09-03 18:11:11.397792454 +0200
+++ b/arch/m68k/Kconfig.machine 2018-10-16 15:32:04.359635259 +0200
@@ -317,7 +317,6 @@ config UBOOT
help
If you say Y here kernel will try to collect command
line parameters from the initial u-boot stack.
- default n
config 4KSTACKS
bool "Use 4Kb for kernel stacks instead of 8Kb"
@@ -395,7 +394,6 @@ comment "ROM configuration"
config ROM
bool "Specify ROM linker regions"
- default n
help
Define a ROM region for the linker script. This creates a kernel
that can be stored in flash, with possibly the text, and data
next parent reply other threads:[~2018-10-16 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f@eucas1p2.samsung.com>
2018-10-16 13:33 ` Bartlomiej Zolnierkiewicz [this message]
2018-12-03 12:29 ` [PATCH] m68k: remove redundant 'default n' from Kconfig Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181016133400eucas1p2f5bab263e70ed0308ce47544fb64a57f~eGh5UqXXL3084730847eucas1p2h@eucas1p2.samsung.com' \
--to=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).