From: Jiri Olsa <jolsa@kernel.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"Herton R. Krzesinski" <herton@redhat.com>
Subject: [PATCH 04/10] tools cpupower: Override CFLAGS assignments
Date: Tue, 16 Oct 2018 17:06:09 +0200 [thread overview]
Message-ID: <20181016150614.21260-5-jolsa@kernel.org> (raw)
In-Reply-To: <20181016150614.21260-1-jolsa@kernel.org>
So user could specify outside CFLAGS values.
Cc: Thomas Renninger <trenn@suse.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/power/cpupower/Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
index 1dd5f4fcffd5..db66a952c173 100644
--- a/tools/power/cpupower/Makefile
+++ b/tools/power/cpupower/Makefile
@@ -129,7 +129,7 @@ WARNINGS += $(call cc-supports,-Wno-pointer-sign)
WARNINGS += $(call cc-supports,-Wdeclaration-after-statement)
WARNINGS += -Wshadow
-CFLAGS += -DVERSION=\"$(VERSION)\" -DPACKAGE=\"$(PACKAGE)\" \
+override CFLAGS += -DVERSION=\"$(VERSION)\" -DPACKAGE=\"$(PACKAGE)\" \
-DPACKAGE_BUGREPORT=\"$(PACKAGE_BUGREPORT)\" -D_GNU_SOURCE
UTIL_OBJS = utils/helpers/amd.o utils/helpers/msr.o \
@@ -156,12 +156,12 @@ LIB_SRC = lib/cpufreq.c lib/cpupower.c lib/cpuidle.c
LIB_OBJS = lib/cpufreq.o lib/cpupower.o lib/cpuidle.o
LIB_OBJS := $(addprefix $(OUTPUT),$(LIB_OBJS))
-CFLAGS += -pipe
+override CFLAGS += -pipe
ifeq ($(strip $(NLS)),true)
INSTALL_NLS += install-gmo
COMPILE_NLS += create-gmo
- CFLAGS += -DNLS
+ override CFLAGS += -DNLS
endif
ifeq ($(strip $(CPUFREQ_BENCH)),true)
@@ -175,7 +175,7 @@ ifeq ($(strip $(STATIC)),true)
UTIL_SRC += $(LIB_SRC)
endif
-CFLAGS += $(WARNINGS)
+override CFLAGS += $(WARNINGS)
ifeq ($(strip $(V)),false)
QUIET=@
@@ -188,10 +188,10 @@ export QUIET ECHO
# if DEBUG is enabled, then we do not strip or optimize
ifeq ($(strip $(DEBUG)),true)
- CFLAGS += -O1 -g -DDEBUG
+ override CFLAGS += -O1 -g -DDEBUG
STRIPCMD = /bin/true -Since_we_are_debugging
else
- CFLAGS += $(OPTIMIZATION) -fomit-frame-pointer
+ override CFLAGS += $(OPTIMIZATION) -fomit-frame-pointer
STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
endif
--
2.17.2
next prev parent reply other threads:[~2018-10-16 15:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 15:06 [PATCH 00/10] tools: Various build flags fixes Jiri Olsa
2018-10-16 15:06 ` [PATCH 01/10] tools lib traceevent: Use LDFLAGS in the build commands Jiri Olsa
2018-10-16 15:21 ` Steven Rostedt
2018-10-16 15:45 ` [PATCHv2 " Jiri Olsa
2018-10-17 14:23 ` Steven Rostedt
2018-11-16 13:01 ` Jiri Olsa
2018-11-22 9:30 ` Jiri Olsa
2018-11-26 18:40 ` Arnaldo Carvalho de Melo
2018-11-28 13:56 ` Arnaldo Carvalho de Melo
2018-12-12 9:12 ` [PATCHv3 " Jiri Olsa
2018-12-12 12:41 ` Arnaldo Carvalho de Melo
2018-12-20 18:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-10-16 15:06 ` [PATCH 02/10] tools perf: Pass build flags to traceevent build Jiri Olsa
2018-10-18 6:20 ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2018-10-30 9:25 ` [PATCH 02/10] tools perf: " Jiri Olsa
2018-10-16 15:06 ` [PATCH 03/10] tools cpupower debug: Allow to use outside build flags Jiri Olsa
2018-10-16 15:06 ` Jiri Olsa [this message]
2018-10-16 15:06 ` [PATCH 05/10] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 06/10] tools thermal tmon: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 07/10] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2018-10-16 15:06 ` [PATCH 08/10] tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 09/10] tools iio: Override CFLAGS assignments Jiri Olsa
2018-10-21 12:26 ` Jonathan Cameron
2018-10-22 8:53 ` Jiri Olsa
2018-10-17 13:23 ` [PATCH 00/10] tools: Various build flags fixes Thomas Renninger
2018-10-17 15:28 ` Shuah Khan
2018-10-22 8:51 ` Jiri Olsa
2018-10-23 15:17 ` Shuah Khan
2018-10-23 16:53 ` Shuah Khan
2018-10-23 17:21 ` Jiri Olsa
2018-10-22 14:50 ` [PATCH 10/10] tools gpio: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016150614.21260-5-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=herton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).