[v2,7/7] staging: bcm2835-audio: update TODO
diff mbox series

Message ID 20181017190156.30010-8-nsaenzjulienne@suse.de
State Accepted
Commit 66845e6fe3ab08bc47060564cad026d7082df1c8
Headers show
  • staging: bcm2835-audio: Cleanups and upgrades
Related show

Commit Message

Nicolas Saenz Julienne Oct. 17, 2018, 7:01 p.m. UTC
The following tasks were completed or not the right solution:

1/2- Not the proper solution, we should register a platform device in
vchiq the same way it's done with bcm2835-camera as commented here:

2/3- Fixed by Takashi Iwai here: https://lkml.org/lkml/2018/9/4/587

Also, adds a new task as per mailing list conversation.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
 .../staging/vc04_services/bcm2835-audio/TODO  | 25 +++----------------
 1 file changed, 3 insertions(+), 22 deletions(-)

diff mbox series

diff --git a/drivers/staging/vc04_services/bcm2835-audio/TODO b/drivers/staging/vc04_services/bcm2835-audio/TODO
index 73d41fa631ac..cb8ead3e9108 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/TODO
+++ b/drivers/staging/vc04_services/bcm2835-audio/TODO
@@ -4,26 +4,7 @@ 
 *                                                                           *
+1) Revisit multi-cards options and PCM route mixer control (as per comment
-1) Document the device tree node
-The downstream tree(the tree that the driver was imported from) at
-http://www.github.com/raspberrypi/linux uses this node:
-audio: audio {
-	compatible = "brcm,bcm2835-audio";
-	brcm,pwm-channels = <8>;
-Since the driver requires the use of VCHIQ, it may be useful to have a link
-in the device tree to the VCHIQ driver.
-2) Gracefully handle the case where VCHIQ is missing from the device tree or
-it has not been initialized yet.
-3) Review error handling and remove duplicate code.
-4) Cleanup the logging mechanism.  The driver should probably be using the
-standard kernel logging mechanisms such as dev_info, dev_dbg, and friends.
-5) Fix the remaining checkpatch.pl errors and warnings.
+2) Fix the remaining checkpatch.pl errors and warnings.