From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: gregkh@linuxfoundation.org
Cc: eric@anholt.net, stefan.wahren@i2se.com,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tiwai@suse.de,
nsaenzjulienne@suse.de, devel@driverdev.osuosl.org
Subject: [PATCH v2 2/7] staging: bcm2835-audio: don't initialize memory twice
Date: Wed, 17 Oct 2018 21:01:51 +0200 [thread overview]
Message-ID: <20181017190156.30010-3-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20181017190156.30010-1-nsaenzjulienne@suse.de>
The memory is being allocated with devres_alloc(), wich ultimately uses
__GFP_ZERO to call kmalloc. We don't need to zero the memory area again
in bcm2835-audio.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
index 87d56ab1ffa0..0efae7068fef 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c
@@ -39,8 +39,6 @@ static int bcm2835_devm_add_vchi_ctx(struct device *dev)
if (!vchi_ctx)
return -ENOMEM;
- memset(vchi_ctx, 0, sizeof(*vchi_ctx));
-
ret = bcm2835_new_vchi_ctx(dev, vchi_ctx);
if (ret) {
devres_free(vchi_ctx);
--
2.19.1
next prev parent reply other threads:[~2018-10-17 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 19:01 [PATCH v2 0/7] staging: bcm2835-audio: Cleanups and upgrades Nicolas Saenz Julienne
2018-10-17 19:01 ` [PATCH v2 1/7] staging: bcm2835-audio: unify FOURCC command definitions Nicolas Saenz Julienne
2018-10-17 19:01 ` Nicolas Saenz Julienne [this message]
2018-10-17 19:01 ` [PATCH v2 3/7] staging: bcm2835-audio: reorder variable declarations & remove trivial comments Nicolas Saenz Julienne
2018-10-17 19:01 ` [PATCH v2 4/7] staging: bcm2835-audio: use anonymous union in struct vc_audio_msg Nicolas Saenz Julienne
2018-10-17 19:01 ` [PATCH v2 5/7] staging: bcm2835-audio: more generic probe function name Nicolas Saenz Julienne
2018-10-17 19:01 ` [PATCH v2 6/7] staging: bcm2835-audio: rename platform_driver structure Nicolas Saenz Julienne
2018-10-17 19:01 ` [PATCH v2 7/7] staging: bcm2835-audio: update TODO Nicolas Saenz Julienne
2018-10-18 18:07 ` [PATCH v2 0/7] staging: bcm2835-audio: Cleanups and upgrades Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017190156.30010-3-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).