test_firmware: fix error return getting clobbered
diff mbox series

Message ID 20181019125801.4544-1-colin.king@canonical.com
State Accepted
Commit 8bb0a88600f0267cfcc245d34f8c4abe8c282713
Headers show
Series
  • test_firmware: fix error return getting clobbered
Related show

Commit Message

Colin King Oct. 19, 2018, 12:58 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

In the case where eq->fw->size > PAGE_SIZE the error return rc
is being set to EINVAL however this is being overwritten to
rc = req->fw->size because the error exit path via label 'out' is
not being taken.  Fix this by adding the jump to the error exit
path 'out'.

Detected by CoverityScan, CID#1453465 ("Unused value")

Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 lib/test_firmware.c | 1 +
 1 file changed, 1 insertion(+)

Patch
diff mbox series

diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index b984806d7d7b..7cab9a9869ac 100644
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -837,6 +837,7 @@  static ssize_t read_firmware_show(struct device *dev,
 	if (req->fw->size > PAGE_SIZE) {
 		pr_err("Testing interface must use PAGE_SIZE firmware for now\n");
 		rc = -EINVAL;
+		goto out;
 	}
 	memcpy(buf, req->fw->data, req->fw->size);