gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc
diff mbox series

Message ID 5bc9ff7e.1c69fb81.105c2.1fef@mx.google.com
State Accepted
Commit 7fea1e0f38a86d2b79ac0a7f31843b4eb55ccb60
Headers show
Series
  • gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc
Related show

Commit Message

Sabyasachi Gupta Oct. 19, 2018, 3:59 p.m. UTC
Replaced kmem_cache_alloc + memset with kmem_cache_zalloc
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
 drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Souptick Joarder Oct. 23, 2018, 4:06 a.m. UTC | #1
On Fri, Oct 19, 2018 at 9:30 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replaced kmem_cache_alloc + memset with kmem_cache_zalloc

Put a new line gap in between these two lines and send v2.

> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 020070d..e001b79 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -98,10 +98,9 @@ virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev,
>  {
>         struct virtio_gpu_vbuffer *vbuf;
>
> -       vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
> +       vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL);
>         if (!vbuf)
>                 return ERR_PTR(-ENOMEM);
> -       memset(vbuf, 0, VBUFFER_SIZE);
>
>         BUG_ON(size > MAX_INLINE_CMD_SIZE);
>         vbuf->buf = (void *)vbuf + sizeof(*vbuf);
> --
> 2.7.4
>
Jani Nikula Oct. 23, 2018, 9:50 a.m. UTC | #2
On Tue, 23 Oct 2018, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On Fri, Oct 19, 2018 at 9:30 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
>>
>> Replaced kmem_cache_alloc + memset with kmem_cache_zalloc
>
> Put a new line gap in between these two lines and send v2.

Nah, the maintainers can trivially add the newline while
applying. Review is much more valuable than nitpicking on the commit
message.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
>> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>> ---
>>  drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
>> index 020070d..e001b79 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
>> @@ -98,10 +98,9 @@ virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev,
>>  {
>>         struct virtio_gpu_vbuffer *vbuf;
>>
>> -       vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
>> +       vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL);
>>         if (!vbuf)
>>                 return ERR_PTR(-ENOMEM);
>> -       memset(vbuf, 0, VBUFFER_SIZE);
>>
>>         BUG_ON(size > MAX_INLINE_CMD_SIZE);
>>         vbuf->buf = (void *)vbuf + sizeof(*vbuf);
>> --
>> 2.7.4
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann Oct. 30, 2018, 5:36 a.m. UTC | #3
On Tue, Oct 23, 2018 at 12:50:36PM +0300, Jani Nikula wrote:
> On Tue, 23 Oct 2018, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > On Fri, Oct 19, 2018 at 9:30 PM Sabyasachi Gupta
> > <sabyasachi.linux@gmail.com> wrote:
> >>
> >> Replaced kmem_cache_alloc + memset with kmem_cache_zalloc
> >
> > Put a new line gap in between these two lines and send v2.
> 
> Nah, the maintainers can trivially add the newline while
> applying. Review is much more valuable than nitpicking on the commit
> message.

Queued (and added newline).

thanks,
  Gerd

Patch
diff mbox series

diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 020070d..e001b79 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -98,10 +98,9 @@  virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev,
 {
 	struct virtio_gpu_vbuffer *vbuf;
 
-	vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
+	vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL);
 	if (!vbuf)
 		return ERR_PTR(-ENOMEM);
-	memset(vbuf, 0, VBUFFER_SIZE);
 
 	BUG_ON(size > MAX_INLINE_CMD_SIZE);
 	vbuf->buf = (void *)vbuf + sizeof(*vbuf);