From: Aaron Ma <aaron.ma@canonical.com>
To: aaron.ma@canonical.com, mathias.nyman@intel.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] usb: xhci: fix timeout for transition from RExit to U0
Date: Mon, 22 Oct 2018 01:08:45 +0800 [thread overview]
Message-ID: <1540141725-13047-2-git-send-email-aaron.ma@canonical.com> (raw)
In-Reply-To: <1540141725-13047-1-git-send-email-aaron.ma@canonical.com>
This definition is used by msecs_to_jiffies in milliseconds.
According to the comments, max rexit timeout should be 20ms.
Align with the comments to properly calculate the delay.
Verified on Sunrise Point-LP and Cannon Lake.
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
drivers/usb/host/xhci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 6230a578324c..30225c53be1c 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1678,7 +1678,7 @@ struct xhci_bus_state {
* It can take up to 20 ms to transition from RExit to U0 on the
* Intel Lynx Point LP xHCI host.
*/
-#define XHCI_MAX_REXIT_TIMEOUT (20 * 1000)
+#define XHCI_MAX_REXIT_TIMEOUT 20
static inline unsigned int hcd_index(struct usb_hcd *hcd)
{
--
2.19.1
next prev parent reply other threads:[~2018-10-21 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 17:08 [PATCH 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status Aaron Ma
2018-10-21 17:08 ` Aaron Ma [this message]
2018-10-21 18:21 ` [PATCH 2/2] usb: xhci: fix timeout for transition from RExit to U0 Greg KH
2018-10-22 3:37 ` Aaron Ma
2018-10-22 13:12 ` [PATCH 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status Mathias Nyman
2018-10-22 13:23 ` Aaron Ma
2018-10-22 17:53 ` Aaron Ma
2018-10-23 10:39 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540141725-13047-2-git-send-email-aaron.ma@canonical.com \
--to=aaron.ma@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).