From: Federico Vaga <federico.vaga@cern.ch>
To: Peter Korsgaard <peter@korsgaard.com>, <linux-i2c@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <federico.vaga@cern.ch>
Subject: [PATCH V2 2/5] i2c:ocores: do not handle IRQ if IF is not set
Date: Mon, 29 Oct 2018 15:50:48 +0100 [thread overview]
Message-ID: <20181029145051.31984-3-federico.vaga@cern.ch> (raw)
In-Reply-To: <20181029145051.31984-1-federico.vaga@cern.ch>
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
---
drivers/i2c/busses/i2c-ocores.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index aa85202..fcc2558 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -143,10 +143,9 @@ static inline u8 oc_getreg(struct ocores_i2c *i2c, int reg)
return i2c->getreg(i2c, reg);
}
-static void ocores_process(struct ocores_i2c *i2c)
+static void ocores_process(struct ocores_i2c *i2c, u8 stat)
{
struct i2c_msg *msg = i2c->msg;
- u8 stat = oc_getreg(i2c, OCI2C_STATUS);
unsigned long flags;
/*
@@ -223,8 +222,12 @@ out:
static irqreturn_t ocores_isr(int irq, void *dev_id)
{
struct ocores_i2c *i2c = dev_id;
+ u8 stat = oc_getreg(i2c, OCI2C_STATUS);
+
+ if (!(stat & OCI2C_STAT_IF))
+ return IRQ_NONE;
- ocores_process(i2c);
+ ocores_process(i2c, stat);
return IRQ_HANDLED;
}
--
2.15.0
next prev parent reply other threads:[~2018-10-29 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 14:50 [PATCH V2 0/5] i2c:ocores: improvements Federico Vaga
2018-10-29 14:50 ` [PATCH V2 1/5] i2c:ocores: stop transfer on timeout Federico Vaga
2018-10-29 14:50 ` Federico Vaga [this message]
2018-10-29 14:50 ` [PATCH V2 3/5] i2c:ocores: add polling interface Federico Vaga
2018-10-29 14:50 ` [PATCH V2 4/5] i2c:ocores: add SPDX tag Federico Vaga
2018-10-29 14:50 ` [PATCH V2 5/5] i2c:ocores: checkpatch fixes Federico Vaga
2018-11-27 11:38 ` [PATCH V2 0/5] i2c:ocores: improvements Wolfram Sang
2019-01-15 16:37 ` Federico Vaga
2019-01-15 22:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029145051.31984-3-federico.vaga@cern.ch \
--to=federico.vaga@cern.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).