From: David Miller <davem@davemloft.net>
To: acme@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] perf: Remove strchr() in map__process_kallsyms_symbol().
Date: Fri, 02 Nov 2018 23:00:30 -0700 (PDT) [thread overview]
Message-ID: <20181102.230030.1309927033490402457.davem@davemloft.net> (raw)
This is looking for '[vdso]', '[vsyscall]' or similar to
force the "kernel" boolean arg to __symbols__insert() to
false.
But such things never show up in kallsyms.
This check was added by commit 608c34de0b3d ("perf symbols: Mark if a
symbol is idle in the library")
Signed-off-by: David S. Miller <davem@davemloft.net>
---
tools/perf/util/symbol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index d188b7588152..345d66d745d1 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -660,7 +660,7 @@ static int map__process_kallsym_symbol(void *arg, const char *name,
* We will pass the symbols to the filter later, in
* map__split_kallsyms, when we have split the maps per module
*/
- __symbols__insert(root, sym, !strchr(name, '['));
+ __symbols__insert(root, sym, true);
return 0;
}
--
2.19.1
reply other threads:[~2018-11-03 6:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102.230030.1309927033490402457.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).