From: Hans Holmberg <hans@owltronix.com>
To: Matias Bjorling <mb@lightnvm.io>
Cc: Javier Gonzales <javier@cnexlabs.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Holmberg <hans.ml.holmberg@owltronix.com>,
Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: [PATCH 6/7] lightnvm: pblk: fix pblk_lines_init error handling path
Date: Mon, 5 Nov 2018 12:41:12 +0100 [thread overview]
Message-ID: <20181105114113.30932-7-hans.ml.holmberg@cnexlabs.com> (raw)
In-Reply-To: <20181105114113.30932-1-hans.ml.holmberg@cnexlabs.com>
From: Hans Holmberg <hans.ml.holmberg@owltronix.com>
From: Hans Holmberg <hans.holmberg@cnexlabs.com>
The chunk metadata is allocated with vmalloc, so we need to use
vfree to free it.
Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
---
drivers/lightnvm/pblk-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 33c1e83327c3..ae9686b5d521 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -1053,7 +1053,7 @@ static int pblk_lines_init(struct pblk *pblk)
pblk_line_meta_free(l_mg, &pblk->lines[i]);
kfree(pblk->lines);
fail_free_chunk_meta:
- kfree(chunk_meta);
+ vfree(chunk_meta);
fail_free_luns:
kfree(pblk->luns);
fail_free_meta:
--
2.17.1
next prev parent reply other threads:[~2018-11-05 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 11:41 [PATCH 0/7] PBLK Bugfixes and cleanups Hans Holmberg
2018-11-05 11:41 ` [PATCH 1/7] lightnvm: pblk: fix resubmission of overwritten write err lbas Hans Holmberg
2018-11-05 11:41 ` [PATCH 2/7] lightnvm: pblk: account for write error sectors in emeta Hans Holmberg
2018-11-05 11:41 ` [PATCH 3/7] lightnvm: pblk: stop writes gracefully when running out of lines Hans Holmberg
2018-11-05 11:41 ` [PATCH 4/7] lightnvm: pblk: set conservative threshold for user writes Hans Holmberg
2018-11-05 16:18 ` kbuild test robot
2018-11-05 11:41 ` [PATCH 5/7] lightnvm: pblk: remove unused macro Hans Holmberg
2018-11-05 11:41 ` Hans Holmberg [this message]
2018-11-05 11:41 ` [PATCH 7/7] lightnvm: pblk: remove dead code in pblk_recov_l2p Hans Holmberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105114113.30932-7-hans.ml.holmberg@cnexlabs.com \
--to=hans@owltronix.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=hans.ml.holmberg@owltronix.com \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).