From: Bo YU <tsu.yubo@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Bo YU <tsu.yubo@gmail.com>,
rafael@kernel.org, linux-kernel@vger.kernel.org, joe@perches.com
Subject: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING
Date: Mon, 5 Nov 2018 21:41:43 -0500 [thread overview]
Message-ID: <1541472103-6212-1-git-send-email-tsu.yubo@gmail.com> (raw)
Fix warning form checkpatch, use pr_warn replace KERN_WARNING
Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
changes in v2:
According to Joe's suggestion,drop newline from msg, otherwise
it can be unterminated with newline.
---
lib/kobject_uevent.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 63d0816ab23b..1837765ebf01 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -195,12 +195,12 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
enum kobject_action action;
const char *action_args;
struct kobj_uevent_env *env;
- const char *msg = NULL, *devpath;
+ const char *msg = NULL;
int r;
r = kobject_action_type(buf, count, &action, &action_args);
if (r) {
- msg = "unknown uevent action string\n";
+ msg = "unknown uevent action string";
goto out;
}
@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
r = kobject_action_args(action_args,
count - (action_args - buf), &env);
if (r == -EINVAL) {
- msg = "incorrect uevent action arguments\n";
+ msg = "incorrect uevent action arguments";
goto out;
}
@@ -223,8 +223,9 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
kfree(env);
out:
if (r) {
- devpath = kobject_get_path(kobj, GFP_KERNEL);
- printk(KERN_WARNING "synth uevent: %s: %s",
+ char *devpath = kobject_get_path(kobj, GFP_KERNEL);
+
+ pr_warn("synth uevent: %s: %s\n",
devpath ?: "unknown device",
msg ?: "failed to send uevent");
kfree(devpath);
--
2.11.0
next reply other threads:[~2018-11-06 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 2:41 Bo YU [this message]
2018-11-06 7:49 ` [PATCH v2] kobject: to use pr_warn replace KERN_WARNING Rafael J. Wysocki
2018-11-06 7:58 ` Joe Perches
2018-11-06 8:09 ` Rafael J. Wysocki
2018-11-06 11:36 ` YU Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541472103-6212-1-git-send-email-tsu.yubo@gmail.com \
--to=tsu.yubo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).