From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
luto@amacapital.net, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, Roman Gushchin <guro@fb.com>,
Juri Lelli <juri.lelli@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Tom Hromatka <tom.hromatka@oracle.com>,
Waiman Long <longman@redhat.com>
Subject: [PATCH v15 09/12] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root
Date: Thu, 8 Nov 2018 10:08:43 -0500 [thread overview]
Message-ID: <1541689726-20088-10-git-send-email-longman@redhat.com> (raw)
In-Reply-To: <1541689726-20088-1-git-send-email-longman@redhat.com>
Because of the fact that setting the "cpuset.sched.partition" in
a direct child of root can remove CPUs from the root's effective CPU
list, it makes sense to know what CPUs are left in the root cgroup for
scheduling purpose. So the "cpuset.cpus.effective" control file is now
exposed in the v2 cgroup root.
For consistency, the "cpuset.mems.effective" control file is exposed
as well.
Signed-off-by: Waiman Long <longman@redhat.com>
---
Documentation/admin-guide/cgroup-v2.rst | 4 ++--
kernel/cgroup/cpuset.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 01b70f6..595b075 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1653,7 +1653,7 @@ Cpuset Interface Files
and won't be affected by any CPU hotplug events.
cpuset.cpus.effective
- A read-only multiple values file which exists on non-root
+ A read-only multiple values file which exists on all
cpuset-enabled cgroups.
It lists the onlined CPUs that are actually granted to this
@@ -1693,7 +1693,7 @@ Cpuset Interface Files
and won't be affected by any memory nodes hotplug events.
cpuset.mems.effective
- A read-only multiple values file which exists on non-root
+ A read-only multiple values file which exists on all
cpuset-enabled cgroups.
It lists the onlined memory nodes that are actually granted to
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 3960de7..fc1a809 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2574,14 +2574,12 @@ static s64 cpuset_read_s64(struct cgroup_subsys_state *css, struct cftype *cft)
.name = "cpus.effective",
.seq_show = cpuset_common_seq_show,
.private = FILE_EFFECTIVE_CPULIST,
- .flags = CFTYPE_NOT_ON_ROOT,
},
{
.name = "mems.effective",
.seq_show = cpuset_common_seq_show,
.private = FILE_EFFECTIVE_MEMLIST,
- .flags = CFTYPE_NOT_ON_ROOT,
},
{
--
1.8.3.1
next prev parent reply other threads:[~2018-11-08 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 15:08 [PATCH v15 00/12] Enable cpuset controller in default hierarchy Waiman Long
2018-11-08 15:08 ` [PATCH v15 01/12] cpuset: " Waiman Long
2018-11-08 15:08 ` [PATCH v15 02/12] cpuset: Define data structures to support scheduling partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 03/12] cpuset: Simply allocation and freeing of cpumasks Waiman Long
2018-11-08 15:08 ` [PATCH v15 04/12] cpuset: Add new v2 cpuset.sched.partition flag Waiman Long
2018-11-08 15:08 ` [PATCH v15 05/12] cpuset: Add an error state to cpuset.sched.partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 06/12] cpuset: Track cpusets that use parent's effective_cpus Waiman Long
2018-11-08 15:08 ` [PATCH v15 07/12] cpuset: Make CPU hotplug work with partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 08/12] cpuset: Make generate_sched_domains() " Waiman Long
2018-11-08 15:08 ` Waiman Long [this message]
2018-11-08 15:08 ` [PATCH v15 10/12] cpuset: Use descriptive text when reading/writing cpuset.sched.partition Waiman Long
2018-11-08 15:08 ` [PATCH v15 11/12] cpuset: Add documentation about the new "cpuset.sched.partition" flag Waiman Long
2018-11-08 15:08 ` [PATCH v15 12/12] cpuset: Expose cpuset.cpus.subpartitions with cgroup_debug Waiman Long
2018-11-08 15:46 ` Peter Zijlstra
2018-11-08 18:59 ` Waiman Long
2018-11-08 15:46 ` [PATCH v15 00/12] Enable cpuset controller in default hierarchy Peter Zijlstra
2018-11-08 20:28 ` Tejun Heo
2018-11-08 20:31 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541689726-20088-10-git-send-email-longman@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=tom.hromatka@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).