[v7,04/17] powerpc/pseries: add of_node_put() in dlpar_detach_node()
diff mbox series

Message ID 1541743565-23163-5-git-send-email-frowand.list@gmail.com
State New, archived
Headers show
  • of: overlay: validation checks, subsequent fixes
Related show

Commit Message

Frank Rowand Nov. 9, 2018, 6:05 a.m. UTC
From: Frank Rowand <frank.rowand@sony.com>

The previous commit, "of: overlay: add missing of_node_get() in
__of_attach_node_sysfs" added a missing of_node_get() to
__of_attach_node_sysfs().  This results in a refcount imbalance
for nodes attached with dlpar_attach_node().  The calling sequence
from dlpar_attach_node() to __of_attach_node_sysfs() is:


For more detailed description of the node refcount, see
commit 68baf692c435 ("powerpc/pseries: Fix of_node_put() underflow
during DLPAR remove").

Tested-by: Alan Tull <atull@kernel.org>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
 arch/powerpc/platforms/pseries/dlpar.c | 2 ++
 1 file changed, 2 insertions(+)

diff mbox series

diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
index 7625546caefd..17958043e7f7 100644
--- a/arch/powerpc/platforms/pseries/dlpar.c
+++ b/arch/powerpc/platforms/pseries/dlpar.c
@@ -270,6 +270,8 @@  int dlpar_detach_node(struct device_node *dn)
 	if (rc)
 		return rc;
+	of_node_put(dn);
 	return 0;