[v7,03/17] of: overlay: add missing of_node_get() in __of_attach_node_sysfs
diff mbox series

Message ID 1541743565-23163-4-git-send-email-frowand.list@gmail.com
State New, archived
Headers show
  • of: overlay: validation checks, subsequent fixes
Related show

Commit Message

Frank Rowand Nov. 9, 2018, 6:05 a.m. UTC
From: Frank Rowand <frank.rowand@sony.com>

There is a matching of_node_put() in __of_detach_node_sysfs()

Remove misleading comment from function header comment for

This patch may result in memory leaks from code that directly calls
the dynamic node add and delete functions directly instead of
using changesets.

This commit should result in powerpc systems that dynamically
allocate a node, then later deallocate the node to have a
memory leak when the node is deallocated.

The next commit will fix the leak.

Tested-by: Alan Tull <atull@kernel.org>
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
 drivers/of/dynamic.c | 3 ---
 drivers/of/kobj.c    | 4 +++-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff mbox series

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index 12c3f9a15e94..146681540487 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -272,9 +272,6 @@  void __of_detach_node(struct device_node *np)
  * of_detach_node() - "Unplug" a node from the device tree.
- *
- * The caller must hold a reference to the node.  The memory associated with
- * the node is not freed until its refcount goes to zero.
 int of_detach_node(struct device_node *np)
diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c
index 7a0a18980b98..c72eef988041 100644
--- a/drivers/of/kobj.c
+++ b/drivers/of/kobj.c
@@ -133,6 +133,9 @@  int __of_attach_node_sysfs(struct device_node *np)
 	if (!name)
 		return -ENOMEM;
+	of_node_get(np);
 	rc = kobject_add(&np->kobj, parent, "%s", name);
 	if (rc)
@@ -159,6 +162,5 @@  void __of_detach_node_sysfs(struct device_node *np)
-	/* finally remove the kobj_init ref */