From: Johannes Berg <johannes@sipsolutions.net>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH v2 3/3] slab: use logical instead of bitwise operation in kmalloc_type()
Date: Fri, 9 Nov 2018 10:35:34 +0100 [thread overview]
Message-ID: <20181109093534.15121-3-johannes@sipsolutions.net> (raw)
In-Reply-To: <20181109093534.15121-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes.berg@intel.com>
The operation here really is more logical than bitwise, even if
due to the setup the bitwise operation works fine. However, this
causes a complaint from sparse that the operation doesn't really
make sense due to the not.
Use a logical and instead of bitwise.
In my (somewhat unscientific) test this caused no differences in
the generated code.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
include/linux/slab.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h
index 918f374e7156..d395c7366312 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -329,7 +329,7 @@ static __always_inline enum kmalloc_cache_type kmalloc_type(gfp_t flags)
* If an allocation is both __GFP_DMA and __GFP_RECLAIMABLE, return
* KMALLOC_DMA and effectively ignore __GFP_RECLAIMABLE
*/
- return type_dma + (is_reclaimable & !is_dma) * KMALLOC_RECLAIM;
+ return type_dma + (is_reclaimable && !is_dma) * KMALLOC_RECLAIM;
}
/*
--
2.17.2
next prev parent reply other threads:[~2018-11-09 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 9:35 [PATCH v2 1/3] compiler-gcc: hide COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW from sparse Johannes Berg
2018-11-09 9:35 ` [PATCH v2 2/3] kernel.h: hide __is_constexpr() " Johannes Berg
2018-11-17 0:45 ` Luc Van Oostenryck
2018-11-09 9:35 ` Johannes Berg [this message]
2018-11-09 18:53 ` [PATCH v2 3/3] slab: use logical instead of bitwise operation in kmalloc_type() Andrew Morton
2018-11-17 0:42 ` [PATCH v2 1/3] compiler-gcc: hide COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW from sparse Luc Van Oostenryck
2018-11-17 11:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109093534.15121-3-johannes@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).