drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer
diff mbox series

Message ID 1541759832-19211-1-git-send-email-ayan.halder@arm.com
State New
Headers show
Series
  • drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer
Related show

Commit Message

Ayan Halder Nov. 9, 2018, 10:37 a.m. UTC
Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
calculate rotation memory requirement in case of AFBC framebuffer. This is
used later to verify if it can be sufficed by the hardware rotation memory
availibility.

Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")
Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
---
 drivers/gpu/drm/arm/malidp_planes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liviu Dudau Nov. 9, 2018, 10:46 a.m. UTC | #1
On Fri, Nov 09, 2018 at 10:37:19AM +0000, Ayan Halder wrote:
> Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
> calculate rotation memory requirement in case of AFBC framebuffer. This is
> used later to verify if it can be sufficed by the hardware rotation memory
> availibility.
> 
> Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")
> Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index c9a6d3e..3f4dc64 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -470,7 +470,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
>  	}
>  
>  	ms->rotmem_size = 0;
> -	if (state->rotation & MALIDP_ROTATED_MASK) {
> +	if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
>  		int val;
>  
>  		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> -- 
> 2.7.4
>
Alexandru-Cosmin Gheorghe Nov. 12, 2018, 12:51 p.m. UTC | #2
Hi Ayan,

On Fri, Nov 09, 2018 at 10:37:19AM +0000, Ayan Halder wrote:
> Rotation memory for layers is shared with AFBC decoder block. Thus one needs to
> calculate rotation memory requirement in case of AFBC framebuffer. This is
> used later to verify if it can be sufficed by the hardware rotation memory
> availibility.
> 
> Fixes: 66da13a ("drm/arm/malidp: Validate rotations for compressed/uncompressed framebuffers for each layer")

Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>

> Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index c9a6d3e..3f4dc64 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -470,7 +470,7 @@ static int malidp_de_plane_check(struct drm_plane *plane,
>  	}
>  
>  	ms->rotmem_size = 0;
> -	if (state->rotation & MALIDP_ROTATED_MASK) {
> +	if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
>  		int val;
>  
>  		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index c9a6d3e..3f4dc64 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -470,7 +470,7 @@  static int malidp_de_plane_check(struct drm_plane *plane,
 	}
 
 	ms->rotmem_size = 0;
-	if (state->rotation & MALIDP_ROTATED_MASK) {
+	if ((state->rotation & MALIDP_ROTATED_MASK) || fb->modifier) {
 		int val;
 
 		val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,