From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Mikulas Patocka <mpatocka@redhat.com>,
Bernie Thompson <bernie@plugable.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: [PATCH] udlfb: fix NULL pointer dereference in dlfb_usb_probe()
Date: Fri, 9 Nov 2018 23:25:10 +0300 [thread overview]
Message-ID: <1541795110-3179-1-git-send-email-khoroshilov@ispras.ru> (raw)
If memory allocation for dlfb fails, error handling code
unconditionally dereference NULL pointer.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 68a958a915ca ("udlfb: handle unplug properly")
---
drivers/video/fbdev/udlfb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 070026a7e55a..9643fe7c8349 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1590,7 +1590,7 @@ static int dlfb_usb_probe(struct usb_interface *intf,
int i;
const struct device_attribute *attr;
struct dlfb_data *dlfb;
- struct fb_info *info;
+ struct fb_info *info = NULL;
int retval = -ENOMEM;
struct usb_device *usbdev = interface_to_usbdev(intf);
@@ -1701,8 +1701,8 @@ static int dlfb_usb_probe(struct usb_interface *intf,
return 0;
error:
- if (dlfb->info) {
- dlfb_ops_destroy(dlfb->info);
+ if (info) {
+ dlfb_ops_destroy(info);
} else if (dlfb) {
usb_put_dev(dlfb->udev);
kfree(dlfb);
--
2.7.4
next reply other threads:[~2018-11-09 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 20:25 Alexey Khoroshilov [this message]
2018-11-12 14:24 ` [PATCH] udlfb: fix NULL pointer dereference in dlfb_usb_probe() Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541795110-3179-1-git-send-email-khoroshilov@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=b.zolnierkie@samsung.com \
--cc=bernie@plugable.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).