linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 09/20] rtc: pic32: Switch to use %ptR
Date: Tue, 13 Nov 2018 19:17:18 +0200	[thread overview]
Message-ID: <20181113171729.19645-10-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181113171729.19645-1-andriy.shevchenko@linux.intel.com>

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-pic32.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/rtc/rtc-pic32.c b/drivers/rtc/rtc-pic32.c
index 3c08eab4f1a8..d7ef0a6f8931 100644
--- a/drivers/rtc/rtc-pic32.c
+++ b/drivers/rtc/rtc-pic32.c
@@ -170,9 +170,7 @@ static int pic32_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
 
 	rtc_tm->tm_year += 100;
 
-	dev_dbg(dev, "read time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
-		rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec);
+	dev_dbg(dev, "read time %ptR\n", rtc_tm);
 
 	clk_disable(pdata->clk);
 	return 0;
@@ -184,9 +182,7 @@ static int pic32_rtc_settime(struct device *dev, struct rtc_time *tm)
 	void __iomem *base = pdata->reg_base;
 	int year = tm->tm_year - 100;
 
-	dev_dbg(dev, "set time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "set time %ptR\n", tm);
 
 	if (year < 0 || year >= 100) {
 		dev_err(dev, "rtc only supports 100 years\n");
@@ -224,10 +220,7 @@ static int pic32_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 	alrm->enabled = (alm_en & PIC32_RTCALRM_ALRMEN) ? 1 : 0;
 
-	dev_dbg(dev, "getalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alm_en,
-		1900 + alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
-		alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec);
+	dev_dbg(dev, "getalarm: %d, %ptR\n", alm_en, alm_tm);
 
 	alm_tm->tm_sec = bcd2bin(alm_tm->tm_sec);
 	alm_tm->tm_min = bcd2bin(alm_tm->tm_min);
@@ -247,10 +240,7 @@ static int pic32_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	void __iomem *base = pdata->reg_base;
 
 	clk_enable(pdata->clk);
-	dev_dbg(dev, "setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alrm->enabled,
-		1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "setalarm: %d, %ptR\n", alrm->enabled, tm);
 
 	writel(0x00, base + PIC32_ALRMTIME);
 	writel(0x00, base + PIC32_ALRMDATE);
-- 
2.19.1


  parent reply	other threads:[~2018-11-13 17:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 17:17 [PATCH v3 00/20] lib, rtc: Print rtc_time via %ptR[dt][rv] Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 01/20] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-11-13 17:35   ` Joe Perches
2018-11-13 18:11     ` Andy Shevchenko
2018-11-20 22:27   ` Alexandre Belloni
2018-11-28 18:16     ` Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 02/20] rtc: Switch to use %ptR Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 03/20] rtc: at91rm9200: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 04/20] rtc: at91sam9: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 05/20] rtc: m41t80: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 06/20] rtc: m48t59: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 07/20] rtc: mcp795: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 08/20] rtc: pcf50633: " Andy Shevchenko
2018-11-13 17:17 ` Andy Shevchenko [this message]
2018-11-13 17:17 ` [PATCH v3 10/20] rtc: pm8xxx: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 11/20] rtc: puv3: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 12/20] rtc: rk808: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 13/20] rtc: rx6110: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 14/20] rtc: rx8025: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 15/20] rtc: s3c: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 16/20] rtc: s5m: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 17/20] rtc: tegra: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 18/20] Input: hp_sdc_rtc - " Andy Shevchenko
2018-11-13 18:07   ` Dmitry Torokhov
2018-11-13 17:17 ` [PATCH v3 19/20] mk68/mac: " Andy Shevchenko
2018-11-13 17:17 ` [PATCH v3 20/20] PM: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113171729.19645-10-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=salyzyn@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).