From: "Moger, Babu" <Babu.Moger@amd.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "corbet@lwn.net" <corbet@lwn.net>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"reinette.chatre@intel.com" <reinette.chatre@intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"qianyue.zj@alibaba-inc.com" <qianyue.zj@alibaba-inc.com>,
"xiaochen.shen@intel.com" <xiaochen.shen@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
"Hurwitz, Sherry" <sherry.hurwitz@amd.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"luto@kernel.org" <luto@kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"jannh@google.com" <jannh@google.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"rian@alum.mit.edu" <rian@alum.mit.edu>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"Moger, Babu" <Babu.Moger@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: [PATCH v8 04/13] arch/resctrl: Bring all the macros to resctrl.h
Date: Fri, 16 Nov 2018 20:54:28 +0000 [thread overview]
Message-ID: <20181116205407.10457-5-babu.moger@amd.com> (raw)
In-Reply-To: <20181116205407.10457-1-babu.moger@amd.com>
Bring all the macros to resctrl.h and rename for consistency.
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
arch/x86/kernel/cpu/resctrl.c | 3 ---
arch/x86/kernel/cpu/resctrl.h | 5 +++++
arch/x86/kernel/cpu/resctrl_monitor.c | 7 ++-----
3 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/resctrl.c b/arch/x86/kernel/cpu/resctrl.c
index 4cea275c7c57..18c8222f326c 100644
--- a/arch/x86/kernel/cpu/resctrl.c
+++ b/arch/x86/kernel/cpu/resctrl.c
@@ -33,9 +33,6 @@
#include <asm/resctrl_sched.h>
#include "resctrl.h"
-#define MBA_IS_LINEAR 0x4
-#define MBA_MAX_MBPS U32_MAX
-
/* Mutex to protect rdtgroup access. */
DEFINE_MUTEX(rdtgroup_mutex);
diff --git a/arch/x86/kernel/cpu/resctrl.h b/arch/x86/kernel/cpu/resctrl.h
index abf5c7e4c625..e5f7bf6a8d09 100644
--- a/arch/x86/kernel/cpu/resctrl.h
+++ b/arch/x86/kernel/cpu/resctrl.h
@@ -12,6 +12,9 @@
#define IA32_L2_CBM_BASE 0xd10
#define IA32_MBA_THRTL_BASE 0xd50
+#define IA32_QM_CTR 0x0c8e
+#define IA32_QM_EVTSEL 0x0c8d
+
#define L3_QOS_CDP_ENABLE 0x01ULL
#define L2_QOS_CDP_ENABLE 0x01ULL
@@ -29,6 +32,8 @@
#define MBM_CNTR_WIDTH 24
#define MBM_OVERFLOW_INTERVAL 1000
#define MAX_MBA_BW 100u
+#define MBA_IS_LINEAR 0x4
+#define MBA_MAX_MBPS U32_MAX
#define RMID_VAL_ERROR BIT_ULL(63)
#define RMID_VAL_UNAVAIL BIT_ULL(62)
diff --git a/arch/x86/kernel/cpu/resctrl_monitor.c b/arch/x86/kernel/cpu/resctrl_monitor.c
index 6d654f7b0eba..9fd62263dabd 100644
--- a/arch/x86/kernel/cpu/resctrl_monitor.c
+++ b/arch/x86/kernel/cpu/resctrl_monitor.c
@@ -28,9 +28,6 @@
#include <asm/cpu_device_id.h>
#include "resctrl.h"
-#define MSR_IA32_QM_CTR 0x0c8e
-#define MSR_IA32_QM_EVTSEL 0x0c8d
-
struct rmid_entry {
u32 rmid;
int busy;
@@ -97,8 +94,8 @@ static u64 __rmid_read(u32 rmid, u32 eventid)
* IA32_QM_CTR.Error (bit 63) and IA32_QM_CTR.Unavailable (bit 62)
* are error bits.
*/
- wrmsr(MSR_IA32_QM_EVTSEL, eventid, rmid);
- rdmsrl(MSR_IA32_QM_CTR, val);
+ wrmsr(IA32_QM_EVTSEL, eventid, rmid);
+ rdmsrl(IA32_QM_CTR, val);
return val;
}
--
2.17.1
next prev parent reply other threads:[~2018-11-16 20:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 20:54 [PATCH v8 00/13] arch/resctrl: AMD QoS support Moger, Babu
2018-11-16 20:54 ` [PATCH v8 01/13] arch/resctrl: Start renaming the rdt files to more generic names Moger, Babu
2018-11-18 14:07 ` Borislav Petkov
2018-11-19 19:13 ` Thomas Gleixner
2018-11-19 20:11 ` Moger, Babu
2018-11-19 20:22 ` Borislav Petkov
2018-11-19 20:26 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 02/13] arch/resctrl: Rename the RDT functions and definitions Moger, Babu
2018-11-16 20:54 ` [PATCH v8 03/13] arch/resctrl: Re-arrange RDT init code Moger, Babu
2018-11-20 9:27 ` Borislav Petkov
2018-11-20 16:31 ` Moger, Babu
2018-11-16 20:54 ` Moger, Babu [this message]
2018-11-20 9:35 ` [PATCH v8 04/13] arch/resctrl: Bring all the macros to resctrl.h Borislav Petkov
2018-11-20 16:32 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 05/13] arch/resctrl: Rename config parameter INTEL_RDT to RESCTRL Moger, Babu
2018-11-20 9:42 ` Borislav Petkov
2018-11-20 19:15 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 06/13] arch/resctrl: Initialize the resource functions that are different Moger, Babu
2018-11-20 9:59 ` Borislav Petkov
2018-11-20 12:05 ` Borislav Petkov
2018-11-21 16:47 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 07/13] arch/resctrl: Bring cbm_validate function into the resource structure Moger, Babu
2018-11-16 20:54 ` [PATCH v8 08/13] arch/resctrl: Add vendor check for MBA software controller Moger, Babu
2018-11-16 20:54 ` [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config parameter Moger, Babu
2018-11-16 21:17 ` Randy Dunlap
2018-11-17 16:30 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 10/13] arch/resctrl: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array Moger, Babu
2018-11-16 20:54 ` [PATCH v8 11/13] arch/resctrl: Introduce QOS feature for AMD Moger, Babu
2018-11-20 12:16 ` Borislav Petkov
2018-11-20 19:40 ` Moger, Babu
2018-11-16 20:54 ` [PATCH v8 12/13] Documentation: Rename and update intel_rdt_ui.txt to resctrl_ui.txt Moger, Babu
2018-11-16 20:54 ` [PATCH v8 13/13] MAINTAINERS: Update the file and documentation names in arch/x86 Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116205407.10457-5-babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=joro@8bytes.org \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=qianyue.zj@alibaba-inc.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=rian@alum.mit.edu \
--cc=sherry.hurwitz@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).