From: Yangtao Li <tiny.windzz@gmail.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH] soc/tegra: refactor soc_is_tegra()
Date: Wed, 21 Nov 2018 09:12:04 -0500 [thread overview]
Message-ID: <20181121141204.22819-1-tiny.windzz@gmail.com> (raw)
of_find_node_by_path() acquires a reference to the node returned by
it and that reference needs to be dropped by its caller.soc_is_tegra()
doesn't do that, so fix it.Call of_machine_is_compatible() to refactor
soc_is_tegra() whcih automatically manages the reference count.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/soc/tegra/common.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
index cd8f41351add..0b40700b672a 100644
--- a/drivers/soc/tegra/common.c
+++ b/drivers/soc/tegra/common.c
@@ -22,11 +22,13 @@ static const struct of_device_id tegra_machine_match[] = {
bool soc_is_tegra(void)
{
- struct device_node *root;
+ struct of_device_id *match = tegra_machine_match;
- root = of_find_node_by_path("/");
- if (!root)
- return false;
+ while(match->compatible){
+ if(of_machine_is_compatible(match->compatible))
+ return true;
+ match++;
+ }
- return of_match_node(tegra_machine_match, root) != NULL;
+ return false;
}
--
2.17.0
next reply other threads:[~2018-11-21 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 14:12 Yangtao Li [this message]
2018-11-21 14:34 ` [PATCH] soc/tegra: refactor soc_is_tegra() Jon Hunter
2018-11-21 14:43 ` Thierry Reding
2018-11-21 14:47 ` Frank Lee
2018-11-21 14:50 ` Jon Hunter
2018-11-21 14:56 ` Thierry Reding
2018-11-21 14:57 ` Frank Lee
2018-11-21 15:28 ` Thierry Reding
2018-11-22 10:45 ` Arnd Bergmann
2018-11-22 10:49 ` Arnd Bergmann
2018-11-22 11:02 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121141204.22819-1-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).