From: Nicholas Mc Guire <hofrat@osadl.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()
Date: Wed, 21 Nov 2018 19:06:12 +0100 [thread overview]
Message-ID: <1542823573-20228-1-git-send-email-hofrat@osadl.org> (raw)
kasprintf() may return NULL on failure of internal allocation thus the
assigned label is not safe if not explicitly checked. On error
mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the
(unlikely) failure case should be fine here.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
---
V2: The dev_err() for the unlikely case of the devm_kasprintf()
failing was removed on request from Bartosz Golaszewski
<bgolaszewski@baylibre.com>
Problem located with experimental coccinelle script
Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y,
GPIOLIB=y, GPIO_MT7621=y
Patch is against 4.20-rc3 (localversion-next is next-20181121)
drivers/gpio/gpio-mt7621.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index d72af6f..1ec95bc 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -244,6 +244,8 @@ mediatek_gpio_bank_probe(struct device *dev,
rg->chip.of_xlate = mediatek_gpio_xlate;
rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d",
dev_name(dev), bank);
+ if (!rg->chip.label)
+ return -ENOMEM;
ret = devm_gpiochip_add_data(dev, &rg->chip, mtk);
if (ret < 0) {
--
2.1.4
next reply other threads:[~2018-11-21 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 18:06 Nicholas Mc Guire [this message]
2018-11-21 18:06 ` [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Nicholas Mc Guire
2018-11-22 16:44 ` Bartosz Golaszewski
2018-11-27 7:49 ` Sean Wang
2018-11-27 8:01 ` Nicholas Mc Guire
2018-11-27 8:32 ` Sean Wang
2018-11-27 8:37 ` Nicholas Mc Guire
2018-11-22 16:39 ` [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf() Bartosz Golaszewski
2018-11-27 7:20 ` Sean Wang
2018-12-07 9:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542823573-20228-1-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).