From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 04/10] staging: rtl8188eu: rename LedCfg to avoid CamelCase
Date: Wed, 21 Nov 2018 20:49:31 +0100 [thread overview]
Message-ID: <20181121194937.1852-4-straube.linux@gmail.com> (raw)
In-Reply-To: <20181121194937.1852-1-straube.linux@gmail.com>
Rename the variable LedCfg to avoid CamleCase.
LedCfg -> led_cfg
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/rtl8188eu/hal/rtl8188eu_led.c | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
index d4495839af34..7e3f04bfd3f0 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_led.c
@@ -12,30 +12,30 @@
void SwLedOn(struct adapter *padapter, struct LED_871x *pLed)
{
- u8 LedCfg;
+ u8 led_cfg;
if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
return;
- LedCfg = usb_read8(padapter, REG_LEDCFG2);
- usb_write8(padapter, REG_LEDCFG2, (LedCfg & 0xf0) | BIT(5) | BIT(6));
+ led_cfg = usb_read8(padapter, REG_LEDCFG2);
+ usb_write8(padapter, REG_LEDCFG2, (led_cfg & 0xf0) | BIT(5) | BIT(6));
pLed->bLedOn = true;
}
void SwLedOff(struct adapter *padapter, struct LED_871x *pLed)
{
- u8 LedCfg;
+ u8 led_cfg;
if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
goto exit;
- LedCfg = usb_read8(padapter, REG_LEDCFG2);/* 0x4E */
+ led_cfg = usb_read8(padapter, REG_LEDCFG2);/* 0x4E */
/* Open-drain arrangement for controlling the LED) */
- LedCfg &= 0x90; /* Set to software control. */
- usb_write8(padapter, REG_LEDCFG2, (LedCfg | BIT(3)));
- LedCfg = usb_read8(padapter, REG_MAC_PINMUX_CFG);
- LedCfg &= 0xFE;
- usb_write8(padapter, REG_MAC_PINMUX_CFG, LedCfg);
+ led_cfg &= 0x90; /* Set to software control. */
+ usb_write8(padapter, REG_LEDCFG2, (led_cfg | BIT(3)));
+ led_cfg = usb_read8(padapter, REG_MAC_PINMUX_CFG);
+ led_cfg &= 0xFE;
+ usb_write8(padapter, REG_MAC_PINMUX_CFG, led_cfg);
exit:
pLed->bLedOn = false;
}
--
2.19.1
next prev parent reply other threads:[~2018-11-21 19:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:49 [PATCH 01/10] staging: rtl8188eu: remove unnecessary parentheses in rtl8188eu_led.c Michael Straube
2018-11-21 19:49 ` [PATCH 02/10] staging: rtl8188eu: cleanup comments " Michael Straube
2018-11-21 19:49 ` [PATCH 03/10] staging: rtl8188eu: add spaces around '&' " Michael Straube
2018-11-21 19:49 ` Michael Straube [this message]
2018-11-21 19:49 ` [PATCH 05/10] staging: rtl8188eu: rename SwLedOn to avoid CamelCase Michael Straube
2018-11-21 19:49 ` [PATCH 06/10] staging: rtl8188eu: rename SwLedOff " Michael Straube
2018-11-21 19:49 ` [PATCH 07/10] staging: rtl8188eu: rename BlinkHandler " Michael Straube
2018-11-21 19:49 ` [PATCH 08/10] staging: rtl8188eu: cleanup a function comment Michael Straube
2018-11-21 19:49 ` [PATCH 09/10] staging: rtl8188eu: rename LedControl8188eu to avoid CamelCase Michael Straube
2018-11-21 19:49 ` [PATCH 10/10] staging: rtl8188eu: rename SwLed0 " Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121194937.1852-4-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).