From: Phil Edworthy <phil.edworthy@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Phil Edworthy <phil.edworthy@renesas.com>
Subject: [PATCH] pinctrl: rzn1: Fix check for used MDIO bus
Date: Fri, 23 Nov 2018 10:54:27 +0000 [thread overview]
Message-ID: <20181123105428.13457-1-phil.edworthy@renesas.com> (raw)
This fixes the check for unused mdio bus setting and the following static
checker warning:
drivers/pinctrl/pinctrl-rzn1.c:198 rzn1_pinctrl_mdio_select()
warn: always true condition '(ipctl->mdio_func[mdio] >= 0) => (0-u32max >= 0)'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
v3:
- Split fixing the return var when calling of_get_child_count() into
a separate patch.
v2:
- Don't rely on rely on the implicit typecast from -1 to uint
---
drivers/pinctrl/pinctrl-rzn1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rzn1.c b/drivers/pinctrl/pinctrl-rzn1.c
index 57886dcff53d..a04235e3bec4 100644
--- a/drivers/pinctrl/pinctrl-rzn1.c
+++ b/drivers/pinctrl/pinctrl-rzn1.c
@@ -112,7 +112,7 @@ struct rzn1_pinctrl {
struct rzn1_pinctrl_regs __iomem *lev2;
u32 lev1_protect_phys;
u32 lev2_protect_phys;
- u32 mdio_func[2];
+ int mdio_func[2];
struct rzn1_pin_group *groups;
unsigned int ngroups;
--
2.17.1
next reply other threads:[~2018-11-23 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 10:54 Phil Edworthy [this message]
2018-11-23 10:54 ` [PATCH] pinctrl: rzn1: Fix of_get_child_count() error check Phil Edworthy
2018-11-23 12:06 ` Geert Uytterhoeven
2018-11-23 12:04 ` [PATCH] pinctrl: rzn1: Fix check for used MDIO bus Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2018-11-19 16:18 Phil Edworthy
2018-11-22 14:08 ` Simon Horman
2018-11-22 14:36 ` Phil Edworthy
2018-11-23 9:40 ` Geert Uytterhoeven
2018-11-23 10:01 ` Phil Edworthy
2018-11-23 10:16 ` Geert Uytterhoeven
2018-11-23 11:06 ` Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123105428.13457-1-phil.edworthy@renesas.com \
--to=phil.edworthy@renesas.com \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).