| Message ID | 20181124093530.GE10969@avx2 |
|---|---|
| State | In Next |
| Commit | e6310f0fb5cd3f65244dbdef2fb264859891c7ec |
| Headers | show |
| Series |
|
| Related | show |
On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote: > -static inline asmlinkage void dump_stack(void) > +static inline void dump_stack(void) Why is it "silly"? An explanation in the commit message would be useful. > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > include/linux/printk.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl) > { > } > > -static inline asmlinkage void dump_stack(void) > +static inline void dump_stack(void) > { > } >
On Sat, Dec 01, 2018 at 09:33:38PM -1000, Joey Pabalinas wrote: > On Sat, Nov 24, 2018 at 12:35:30PM +0300, Alexey Dobriyan wrote: > > -static inline asmlinkage void dump_stack(void) > > +static inline void dump_stack(void) > > Why is it "silly"? An explanation in the commit message would be useful. Empty function will be inlined so asmlinkage doesn't do anything.
On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote: > Empty function will be inlined so asmlinkage doesn't do anything. Yes, that is an example of a perfect explanation to have in the commit message :) Ack from me after that addition. Acked-by: Joey Pabalinas <joeypabalinas@gmail.com>
--- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl) { } -static inline asmlinkage void dump_stack(void) +static inline void dump_stack(void) { }
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- include/linux/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)