From: Nishad Kamdar <nishadkamdar@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH 04/26] Staging: fbtft: flexfb: Switch to the gpio descriptor interface
Date: Sun, 25 Nov 2018 16:56:29 +0530 [thread overview]
Message-ID: <0bc27a5c4f06e50f9cc2d568c6ce5f983dc84925.1543142440.git.nishadkamdar@gmail.com> (raw)
In-Reply-To: <cover.1543142440.git.nishadkamdar@gmail.com>
This switches the flexfb.c to use GPIO descriptors
rather than numerical gpios.
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
drivers/staging/fbtft/flexfb.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index 2af474469e7d..c5fa59105a43 100644
--- a/drivers/staging/fbtft/flexfb.c
+++ b/drivers/staging/fbtft/flexfb.c
@@ -9,7 +9,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/vmalloc.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/spi/spi.h>
#include <linux/delay.h>
@@ -521,7 +521,7 @@ static int flexfb_verify_gpios_dc(struct fbtft_par *par)
{
fbtft_par_dbg(DEBUG_VERIFY_GPIOS, par, "%s()\n", __func__);
- if (par->gpio.dc < 0) {
+ if (!par->gpio.dc) {
dev_err(par->info->device,
"Missing info about 'dc' gpio. Aborting.\n");
return -EINVAL;
@@ -537,22 +537,22 @@ static int flexfb_verify_gpios_db(struct fbtft_par *par)
fbtft_par_dbg(DEBUG_VERIFY_GPIOS, par, "%s()\n", __func__);
- if (par->gpio.dc < 0) {
+ if (!par->gpio.dc) {
dev_err(par->info->device, "Missing info about 'dc' gpio. Aborting.\n");
return -EINVAL;
}
- if (par->gpio.wr < 0) {
+ if (!par->gpio.wr) {
dev_err(par->info->device, "Missing info about 'wr' gpio. Aborting.\n");
return -EINVAL;
}
- if (latched && (par->gpio.latch < 0)) {
+ if (latched && !par->gpio.latch) {
dev_err(par->info->device, "Missing info about 'latch' gpio. Aborting.\n");
return -EINVAL;
}
if (latched)
num_db = buswidth / 2;
for (i = 0; i < num_db; i++) {
- if (par->gpio.db[i] < 0) {
+ if (!par->gpio.db[i]) {
dev_err(par->info->device,
"Missing info about 'db%02d' gpio. Aborting.\n",
i);
--
2.17.1
next prev parent reply other threads:[~2018-11-25 11:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 11:20 [PATCH 00/26] Staging: fbtft: Switch to the gpio descriptor interface Nishad Kamdar
2018-11-25 11:23 ` [PATCH 01/26] Staging: fbtft: fbtft-core: " Nishad Kamdar
2018-11-25 16:12 ` kbuild test robot
2018-11-25 11:24 ` [PATCH 02/26] Staging: fbtft: fbtft-bus: " Nishad Kamdar
2018-11-25 11:25 ` [PATCH 03/26] Staging: fbtft: fbtft-io: " Nishad Kamdar
2018-11-25 11:26 ` Nishad Kamdar [this message]
2018-11-26 10:13 ` [PATCH 04/26] Staging: fbtft: flexfb: " Dan Carpenter
2018-12-04 15:56 ` Nishad Kamdar
2018-11-25 11:27 ` [PATCH 05/26] Staging: fbtft: fbtft-device: " Nishad Kamdar
2018-11-25 11:28 ` [PATCH 06/26] Staging: fbtft: fb_upd161704: " Nishad Kamdar
2018-11-25 11:29 ` [PATCH 07/26] Staging: fbtft: fb_sh1106: " Nishad Kamdar
2018-11-25 11:29 ` [PATCH 08/26] Staging: fbtft: fb_uc1611: " Nishad Kamdar
2018-11-25 11:30 ` [PATCH 09/26] Staging: fbtft: fb_s6d1211: " Nishad Kamdar
2018-11-25 11:31 ` [PATCH 10/26] Staging: fbtft: fb_ili9320: " Nishad Kamdar
2018-11-25 11:32 ` [PATCH 11/26] Staging: fbtft: fb_ili9340: " Nishad Kamdar
2018-11-25 11:34 ` [PATCH 12/26] Staging: fbtft: fb_ssd1325: " Nishad Kamdar
2018-11-25 11:35 ` [PATCH 13/26] Staging: fbtft: fb_ili9325: " Nishad Kamdar
2018-11-25 11:35 ` [PATCH 14/26] Staging: fbtft: fb_ssd1289: " Nishad Kamdar
2018-11-25 11:36 ` [PATCH 15/26] Staging: fbtft: fb_ssd1351: " Nishad Kamdar
2018-11-25 11:37 ` [PATCH 16/26] Staging: fbtft: fb_uc1701: " Nishad Kamdar
2018-11-25 11:37 ` [PATCH 17/26] Staging: fbtft: fb_ssd1306: " Nishad Kamdar
2018-11-25 11:38 ` [PATCH 18/26] Staging: fbtft: fb_bd663474: " Nishad Kamdar
2018-11-25 11:39 ` [PATCH 19/26] Staging: fbtft: fb_ssd1331: " Nishad Kamdar
2018-11-25 11:39 ` [PATCH 20/26] Staging: fbtft: fb_ili9163: " Nishad Kamdar
2018-11-25 11:40 ` [PATCH 21/26] Staging: fbtft: fb_agm1264k-fl: " Nishad Kamdar
2018-11-25 11:41 ` [PATCH 22/26] Staging: fbtft: fb_pcd8544: " Nishad Kamdar
2018-11-25 11:42 ` [PATCH 23/26] Staging: fbtft: fb_ssd1305: " Nishad Kamdar
2018-11-25 11:43 ` [PATCH 24/26] Staging: fbtft: fb_tls8204: " Nishad Kamdar
2018-11-25 11:43 ` [PATCH 25/26] Staging: fbtft: fb_watterott: " Nishad Kamdar
2018-11-25 11:44 ` [PATCH 26/26] Staging: fbtft: fb_ra8875: " Nishad Kamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc27a5c4f06e50f9cc2d568c6ce5f983dc84925.1543142440.git.nishadkamdar@gmail.com \
--to=nishadkamdar@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).