linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v5 15/21] rtc: rx8025: Switch to use %ptR
Date: Thu, 29 Nov 2018 12:59:53 +0200	[thread overview]
Message-ID: <20181129105956.25933-16-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181129105956.25933-1-andriy.shevchenko@linux.intel.com>

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-rx8025.c | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c
index 41127adf5765..41de38acc570 100644
--- a/drivers/rtc/rtc-rx8025.c
+++ b/drivers/rtc/rtc-rx8025.c
@@ -193,10 +193,7 @@ static int rx8025_get_time(struct device *dev, struct rtc_time *dt)
 	if (err)
 		return err;
 
-	dev_dbg(dev, "%s: read 0x%02x 0x%02x "
-		"0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n", __func__,
-		date[0], date[1], date[2], date[3], date[4],
-		date[5], date[6]);
+	dev_dbg(dev, "%s: read %7ph\n", __func__, date);
 
 	dt->tm_sec = bcd2bin(date[RX8025_REG_SEC] & 0x7f);
 	dt->tm_min = bcd2bin(date[RX8025_REG_MIN] & 0x7f);
@@ -210,9 +207,7 @@ static int rx8025_get_time(struct device *dev, struct rtc_time *dt)
 	dt->tm_mon = bcd2bin(date[RX8025_REG_MONTH] & 0x1f) - 1;
 	dt->tm_year = bcd2bin(date[RX8025_REG_YEAR]) + 100;
 
-	dev_dbg(dev, "%s: date %ds %dm %dh %dmd %dm %dy\n", __func__,
-		dt->tm_sec, dt->tm_min, dt->tm_hour,
-		dt->tm_mday, dt->tm_mon, dt->tm_year);
+	dev_dbg(dev, "%s: date %ptRr\n", __func__, dt);
 
 	return 0;
 }
@@ -243,10 +238,7 @@ static int rx8025_set_time(struct device *dev, struct rtc_time *dt)
 	date[RX8025_REG_MONTH] = bin2bcd(dt->tm_mon + 1);
 	date[RX8025_REG_YEAR] = bin2bcd(dt->tm_year - 100);
 
-	dev_dbg(dev,
-		"%s: write 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x 0x%02x\n",
-		__func__,
-		date[0], date[1], date[2], date[3], date[4], date[5], date[6]);
+	dev_dbg(dev, "%s: write %7ph\n", __func__, date);
 
 	ret = rx8025_write_regs(rx8025->client, RX8025_REG_SEC, 7, date);
 	if (ret < 0)
@@ -319,10 +311,7 @@ static int rx8025_read_alarm(struct device *dev, struct rtc_wkalrm *t)
 		t->time.tm_hour = bcd2bin(ald[1] & 0x1f) % 12
 			+ (ald[1] & 0x20 ? 12 : 0);
 
-	dev_dbg(dev, "%s: date: %ds %dm %dh %dmd %dm %dy\n",
-		__func__,
-		t->time.tm_sec, t->time.tm_min, t->time.tm_hour,
-		t->time.tm_mday, t->time.tm_mon, t->time.tm_year);
+	dev_dbg(dev, "%s: date: %ptRr\n", __func__, t);
 	t->enabled = !!(rx8025->ctrl1 & RX8025_BIT_CTRL1_DALE);
 	t->pending = (ctrl2 & RX8025_BIT_CTRL2_DAFG) && t->enabled;
 
-- 
2.19.2


  parent reply	other threads:[~2018-11-29 11:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 10:59 [PATCH v5 00/21] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 01/21] nvmem: Move nvmem_type_str array to its only user Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 02/21] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-04 13:30   ` Petr Mladek
2018-12-04 16:12     ` Andy Shevchenko
2018-12-04 16:16       ` Geert Uytterhoeven
2018-12-04 16:38         ` Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 03/21] rtc: Switch to use %ptR Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 04/21] rtc: at91rm9200: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 05/21] rtc: at91sam9: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 06/21] rtc: m41t80: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 07/21] rtc: m48t59: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 08/21] rtc: mcp795: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 09/21] rtc: pcf50633: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 10/21] rtc: pic32: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 11/21] rtc: pm8xxx: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 12/21] rtc: puv3: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 13/21] rtc: rk808: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 14/21] rtc: rx6110: " Andy Shevchenko
2018-11-29 10:59 ` Andy Shevchenko [this message]
2018-11-29 10:59 ` [PATCH v5 16/21] rtc: s3c: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 17/21] rtc: s5m: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 18/21] rtc: tegra: " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 19/21] Input: hp_sdc_rtc - " Andy Shevchenko
2018-11-29 10:59 ` [PATCH v5 20/21] m68k/mac: " Andy Shevchenko
2018-12-02  9:42   ` Geert Uytterhoeven
2018-11-29 10:59 ` [PATCH v5 21/21] PM: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129105956.25933-16-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=salyzyn@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).