From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Michal Simek <monstr@monstr.eu>
Cc: linux-kbuild@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails
Date: Mon, 3 Dec 2018 16:50:57 +0900 [thread overview]
Message-ID: <1543823457-32478-8-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1543823457-32478-1-git-send-email-yamada.masahiro@socionext.com>
I guess
|| (rm -f $@ && echo false)
... should be
|| (rm -f $@ && false)
since printing the string "false" on the console has no point.
Moreover, no Makefile needs to delete a target on error explicitly
since commit 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special
target").
Reuse equivalent cmd_shipped from scripts/Makefile.lib.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/microblaze/boot/dts/Makefile | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/microblaze/boot/dts/Makefile b/arch/microblaze/boot/dts/Makefile
index c7324e7..ef00dd3 100644
--- a/arch/microblaze/boot/dts/Makefile
+++ b/arch/microblaze/boot/dts/Makefile
@@ -12,12 +12,9 @@ $(obj)/linked_dtb.o: $(obj)/system.dtb
# Generate system.dtb from $(DTB).dtb
ifneq ($(DTB),system)
$(obj)/system.dtb: $(obj)/$(DTB).dtb
- $(call if_changed,cp)
+ $(call if_changed,shipped)
endif
endif
-quiet_cmd_cp = CP $< $@$2
- cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
-
# Rule to build device tree blobs
DTC_FLAGS := -p 1024
--
2.7.4
next prev parent reply other threads:[~2018-12-03 7:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 7:50 [PATCH 0/7] microblaze: fix various problems in building boot images Masahiro Yamada
2018-12-03 7:50 ` [PATCH 1/7] microblaze: fix cleaning of " Masahiro Yamada
2018-12-05 15:41 ` Michal Simek
2018-12-03 7:50 ` [PATCH 2/7] microblaze: adjust the help to the real behavior Masahiro Yamada
2018-12-05 15:40 ` Michal Simek
2018-12-06 5:27 ` Masahiro Yamada
2018-12-06 12:52 ` Michal Simek
2018-12-07 9:50 ` Masahiro Yamada
2018-12-07 10:21 ` Masahiro Yamada
2018-12-07 10:47 ` Michal Simek
2018-12-03 7:50 ` [PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile Masahiro Yamada
2018-12-05 15:47 ` Michal Simek
2018-12-03 7:50 ` [PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile Masahiro Yamada
2018-12-05 15:57 ` Michal Simek
2018-12-03 7:50 ` [PATCH 5/7] microblaze: add linux.bin* and simpleImage.* to PHONY Masahiro Yamada
2018-12-05 15:59 ` Michal Simek
2018-12-03 7:50 ` [PATCH 6/7] microblaze: fix race condition in building boot images Masahiro Yamada
2018-12-05 16:31 ` Michal Simek
2018-12-08 6:51 ` Masahiro Yamada
2018-12-03 7:50 ` Masahiro Yamada [this message]
2018-12-05 16:33 ` [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails Michal Simek
2018-12-05 16:41 ` [PATCH 0/7] microblaze: fix various problems in building boot images Michal Simek
2018-12-06 5:08 ` Masahiro Yamada
2018-12-06 13:09 ` Michal Simek
2018-12-07 11:25 ` Masahiro Yamada
2018-12-06 14:44 ` Michal Simek
2018-12-07 11:29 ` Masahiro Yamada
2018-12-07 13:29 ` Michal Simek
2018-12-07 15:19 ` Michal Simek
2018-12-08 6:14 ` Masahiro Yamada
2018-12-12 13:50 ` Michal Simek
2018-12-12 14:11 ` Masahiro Yamada
2018-12-12 14:21 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543823457-32478-8-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).