From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Michal Simek <monstr@monstr.eu>
Cc: linux-kbuild@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile
Date: Mon, 3 Dec 2018 16:50:54 +0900 [thread overview]
Message-ID: <1543823457-32478-5-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1543823457-32478-1-git-send-email-yamada.masahiro@socionext.com>
This Makefile is wrong in multiple ways.
The first issue is the breakage of 'linux.bin.ub' target since commit
ece97f3a5fb5 ("microblaze: Fix simpleImage format generation")
because the addition of UIMAGE_{IN,OUT} obviously affected it.
make ARCH=microblaze CROSS_COMPILE=microblaze-linux- linux.bin.ub
[ snip ]
OBJCOPY arch/microblaze/boot/linux.bin
UIMAGE arch/microblaze/boot/linux.bin.ub.ub
/usr/bin/mkimage: Can't open arch/microblaze/boot/linux.bin.ub: No such file or directory
make[1]: *** [arch/microblaze/boot/Makefile;14: arch/microblaze/boot/linux.bin.ub] Error 1
make: *** [arch/microblaze/Makefile;83: linux.bin.ub] Error 2
The second issue is the use of the "if_changed" multiple times for
the same target.
As commit 92a4728608a8 ("x86/boot: Fix if_changed build flip/flop bug")
pointed out, this never works properly. Moreover, generating multiple
images as a side-effect is extremely confusing and wrong.
As far as I understood, "simpleImage.<dt>" works like a phony target
to generate the following four images.
- arch/microblaze/boot/simpleImage.<dt>:
identical to arch/microblaze/boot/linux.bin
- arch/microblaze/boot/simpleImage.<dt>.unstrip:
identical to vmlinux
- arch/microblaze/boot/simpleImage.<dt>.ub:
identical to arch/microblaze/boot/linux.bin.ub
- arch/microblaze/boot/simpleImage.<dt>.strip:
stripped vmlinux
The first three are just aliases of other images. Separate the recipe
for each image.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/microblaze/Makefile | 2 +-
arch/microblaze/boot/Makefile | 27 ++++++++++++++++-----------
2 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
index cfd7bfca..c5d5b0e 100644
--- a/arch/microblaze/Makefile
+++ b/arch/microblaze/Makefile
@@ -84,7 +84,7 @@ linux.bin linux.bin.gz linux.bin.ub: vmlinux
@echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
simpleImage.%: vmlinux
- $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
+ $(Q)$(MAKE) $(build)=$(boot) simple_images
@echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
define archhelp
diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
index c2579a7..f12a9d7 100644
--- a/arch/microblaze/boot/Makefile
+++ b/arch/microblaze/boot/Makefile
@@ -3,7 +3,7 @@
# arch/microblaze/boot/Makefile
#
-targets := linux.bin linux.bin.gz linux.bin.ub simpleImage.%
+targets := linux.bin linux.bin.gz linux.bin.ub simpleImage.*.strip
OBJCOPYFLAGS := -R .note -R .comment -R .note.gnu.build-id -O binary
@@ -16,21 +16,26 @@ $(obj)/linux.bin.ub: $(obj)/linux.bin FORCE
$(obj)/linux.bin.gz: $(obj)/linux.bin FORCE
$(call if_changed,gzip)
-quiet_cmd_cp = CP $< $@$2
- cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
-
quiet_cmd_strip = STRIP $< $@$2
cmd_strip = $(STRIP) -K microblaze_start -K _end -K __log_buf \
-K _fdt_start $< -o $@$2
UIMAGE_LOADADDR = $(CONFIG_KERNEL_BASE_ADDR)
-UIMAGE_IN = $@
-UIMAGE_OUT = $@.ub
-$(obj)/simpleImage.%: vmlinux FORCE
- $(call if_changed,cp,.unstrip)
- $(call if_changed,objcopy)
- $(call if_changed,uimage)
- $(call if_changed,strip,.strip)
+PHONY += simple_images
+simple_images: $(addprefix $(obj)/simpleImage., $(DTB) $(DTB).ub $(DTB).unstrip $(DTB).strip)
+ @:
+
+$(obj)/simpleImage.$(DTB): $(obj)/linux.bin
+ $(call cmd,shipped)
+
+$(obj)/simpleImage.$(DTB).ub: $(obj)/linux.bin.ub
+ $(call cmd,shipped)
+
+$(obj)/simpleImage.$(DTB).unstrip: vmlinux
+ $(call cmd,shipped)
+
+$(obj)/simpleImage.$(DTB).strip: vmlinux FORCE
+ $(call if_changed,strip)
clean-files += simpleImage.*
--
2.7.4
next prev parent reply other threads:[~2018-12-03 7:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 7:50 [PATCH 0/7] microblaze: fix various problems in building boot images Masahiro Yamada
2018-12-03 7:50 ` [PATCH 1/7] microblaze: fix cleaning of " Masahiro Yamada
2018-12-05 15:41 ` Michal Simek
2018-12-03 7:50 ` [PATCH 2/7] microblaze: adjust the help to the real behavior Masahiro Yamada
2018-12-05 15:40 ` Michal Simek
2018-12-06 5:27 ` Masahiro Yamada
2018-12-06 12:52 ` Michal Simek
2018-12-07 9:50 ` Masahiro Yamada
2018-12-07 10:21 ` Masahiro Yamada
2018-12-07 10:47 ` Michal Simek
2018-12-03 7:50 ` [PATCH 3/7] microblaze: move "... is ready" message to arch/microblaze/Makefile Masahiro Yamada
2018-12-05 15:47 ` Michal Simek
2018-12-03 7:50 ` Masahiro Yamada [this message]
2018-12-05 15:57 ` [PATCH 4/7] microblaze: fix multiple bugs in arch/microblaze/boot/Makefile Michal Simek
2018-12-03 7:50 ` [PATCH 5/7] microblaze: add linux.bin* and simpleImage.* to PHONY Masahiro Yamada
2018-12-05 15:59 ` Michal Simek
2018-12-03 7:50 ` [PATCH 6/7] microblaze: fix race condition in building boot images Masahiro Yamada
2018-12-05 16:31 ` Michal Simek
2018-12-08 6:51 ` Masahiro Yamada
2018-12-03 7:50 ` [PATCH 7/7] microblaze: remove the unneeded code just in case file copy fails Masahiro Yamada
2018-12-05 16:33 ` Michal Simek
2018-12-05 16:41 ` [PATCH 0/7] microblaze: fix various problems in building boot images Michal Simek
2018-12-06 5:08 ` Masahiro Yamada
2018-12-06 13:09 ` Michal Simek
2018-12-07 11:25 ` Masahiro Yamada
2018-12-06 14:44 ` Michal Simek
2018-12-07 11:29 ` Masahiro Yamada
2018-12-07 13:29 ` Michal Simek
2018-12-07 15:19 ` Michal Simek
2018-12-08 6:14 ` Masahiro Yamada
2018-12-12 13:50 ` Michal Simek
2018-12-12 14:11 ` Masahiro Yamada
2018-12-12 14:21 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543823457-32478-5-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).