From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
Dave Emett <david.emett@broadcom.com>,
Thomas Spurden <thomas.spurden@broadcom.com>,
Eric Anholt <eric@anholt.net>
Subject: [PATCH v2 5/6] drm/v3d: Stop trying to flush L2C on V3D 3.3+
Date: Mon, 3 Dec 2018 14:24:37 -0800 [thread overview]
Message-ID: <20181203222438.25417-5-eric@anholt.net> (raw)
In-Reply-To: <20181203222438.25417-1-eric@anholt.net>
This cache was replaced with the slice accessing the L2T in the newer
generations. Noted by Dave during review.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/v3d/v3d_gem.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index c268c7c79566..8a4be9515179 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -130,10 +130,15 @@ v3d_flush_l3(struct v3d_dev *v3d)
}
}
-/* Invalidates the (read-only) L2 cache. */
+/* Invalidates the (read-only) L2C cache. This was the L2 cache for
+ * uniforms and instructions on V3D 3.2.
+ */
static void
-v3d_invalidate_l2(struct v3d_dev *v3d, int core)
+v3d_invalidate_l2c(struct v3d_dev *v3d, int core)
{
+ if (v3d->ver > 32)
+ return;
+
V3D_CORE_WRITE(core, V3D_CTL_L2CACTL,
V3D_L2CACTL_L2CCLR |
V3D_L2CACTL_L2CENA);
@@ -168,7 +173,7 @@ v3d_invalidate_caches(struct v3d_dev *v3d)
{
v3d_flush_l3(v3d);
- v3d_invalidate_l2(v3d, 0);
+ v3d_invalidate_l2c(v3d, 0);
v3d_invalidate_slices(v3d, 0);
v3d_flush_l2t(v3d, 0);
}
--
2.20.0.rc1
next prev parent reply other threads:[~2018-12-03 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 22:24 [PATCH v2 1/6] drm/v3d: Document cache flushing ABI Eric Anholt
2018-12-03 22:24 ` [PATCH v2 2/6] drm/v3d: Drop unused v3d_flush_caches() Eric Anholt
2018-12-03 22:24 ` [PATCH v2 3/6] drm/v3d: Don't bother flushing L1TD at job start Eric Anholt
2018-12-03 22:24 ` [PATCH v2 4/6] drm/v3d: Drop the wait for L2T flush to complete Eric Anholt
2018-12-04 11:53 ` Dave Emett
2018-12-03 22:24 ` Eric Anholt [this message]
2018-12-04 11:54 ` [PATCH v2 5/6] drm/v3d: Stop trying to flush L2C on V3D 3.3+ Dave Emett
2018-12-03 22:24 ` [PATCH v2 6/6] drm/v3d: Invalidate the caches from the outside in Eric Anholt
2018-12-04 12:01 ` Dave Emett
2018-12-04 11:51 ` [PATCH v2 1/6] drm/v3d: Document cache flushing ABI Dave Emett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203222438.25417-5-eric@anholt.net \
--to=eric@anholt.net \
--cc=david.emett@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.spurden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).