From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v6 12/20] rtc: rk808: Switch to use %ptR
Date: Tue, 4 Dec 2018 23:23:22 +0200 [thread overview]
Message-ID: <20181204212330.69515-13-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rtc/rtc-rk808.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/rtc/rtc-rk808.c b/drivers/rtc/rtc-rk808.c
index b2f9e45e0298..1fb864d4ef83 100644
--- a/drivers/rtc/rtc-rk808.c
+++ b/drivers/rtc/rtc-rk808.c
@@ -138,9 +138,7 @@ static int rk808_rtc_readtime(struct device *dev, struct rtc_time *tm)
tm->tm_year = (bcd2bin(rtc_data[5] & YEARS_REG_MSK)) + 100;
tm->tm_wday = bcd2bin(rtc_data[6] & WEEKS_REG_MSK);
rockchip_to_gregorian(tm);
- dev_dbg(dev, "RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
- 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
- tm->tm_wday, tm->tm_hour, tm->tm_min, tm->tm_sec);
+ dev_dbg(dev, "RTC date/time %ptRd(%d) %ptRt\n", tm, tm->tm_wday, tm);
return ret;
}
@@ -153,9 +151,7 @@ static int rk808_rtc_set_time(struct device *dev, struct rtc_time *tm)
u8 rtc_data[NUM_TIME_REGS];
int ret;
- dev_dbg(dev, "set RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
- 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
- tm->tm_wday, tm->tm_hour, tm->tm_min, tm->tm_sec);
+ dev_dbg(dev, "set RTC date/time %ptRd(%d) %ptRt\n", tm, tm->tm_wday, tm);
gregorian_to_rockchip(tm);
rtc_data[0] = bin2bcd(tm->tm_sec);
rtc_data[1] = bin2bcd(tm->tm_min);
@@ -216,10 +212,8 @@ static int rk808_rtc_readalarm(struct device *dev, struct rtc_wkalrm *alrm)
return ret;
}
- dev_dbg(dev, "alrm read RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
- 1900 + alrm->time.tm_year, alrm->time.tm_mon + 1,
- alrm->time.tm_mday, alrm->time.tm_wday, alrm->time.tm_hour,
- alrm->time.tm_min, alrm->time.tm_sec);
+ dev_dbg(dev, "alrm read RTC date/time %ptRd(%d) %ptRt\n",
+ &alrm->time, alrm->time.tm_wday, &alrm->time);
alrm->enabled = (int_reg & BIT_RTC_INTERRUPTS_REG_IT_ALARM_M) ? 1 : 0;
@@ -261,10 +255,8 @@ static int rk808_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
dev_err(dev, "Failed to stop alarm: %d\n", ret);
return ret;
}
- dev_dbg(dev, "alrm set RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
- 1900 + alrm->time.tm_year, alrm->time.tm_mon + 1,
- alrm->time.tm_mday, alrm->time.tm_wday, alrm->time.tm_hour,
- alrm->time.tm_min, alrm->time.tm_sec);
+ dev_dbg(dev, "alrm set RTC date/time %ptRd(%d) %ptRt\n",
+ &alrm->time, alrm->time.tm_wday, &alrm->time);
gregorian_to_rockchip(&alrm->time);
alrm_data[0] = bin2bcd(alrm->time.tm_sec);
--
2.19.2
next prev parent reply other threads:[~2018-12-04 21:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:23 [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 01/20] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-10 9:09 ` Andy Shevchenko
2018-12-10 14:51 ` Petr Mladek
2018-12-04 21:23 ` [PATCH v6 02/20] rtc: Switch to use %ptR Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 03/20] rtc: at91rm9200: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 04/20] rtc: at91sam9: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 05/20] rtc: m41t80: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 06/20] rtc: m48t59: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 07/20] rtc: mcp795: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 08/20] rtc: pcf50633: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 09/20] rtc: pic32: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 10/20] rtc: pm8xxx: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 11/20] rtc: puv3: " Andy Shevchenko
2018-12-04 21:23 ` Andy Shevchenko [this message]
2018-12-04 21:23 ` [PATCH v6 13/20] rtc: rx6110: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 14/20] rtc: rx8025: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 15/20] rtc: s3c: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 16/20] rtc: s5m: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 17/20] rtc: tegra: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 18/20] Input: hp_sdc_rtc - " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 19/20] m68k/mac: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 20/20] PM: " Andy Shevchenko
2018-12-11 11:53 ` Rafael J. Wysocki
2018-12-11 12:29 ` Andy Shevchenko
2018-12-11 10:53 ` [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204212330.69515-13-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=salyzyn@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).