linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 08/15 v4] gpio: Enable nonexclusive gpiods from DT nodes
Date: Thu,  6 Dec 2018 13:43:44 +0100	[thread overview]
Message-ID: <20181206124351.10155-9-linus.walleij@linaro.org> (raw)
In-Reply-To: <20181206124351.10155-1-linus.walleij@linaro.org>

This makes gpiod_get_from_of_node() respect the
GPIOD_FLAGS_BIT_NONEXCLUSIVE flag which is especially
nice when getting regulator GPIOs right out of device
tree nodes.

Cc: Mark Brown <broonie@kernel.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: b0ce7b29bfcd ("regulator/gpio: Allow nonexclusive GPIO access")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v3->v4:
- Resending.
ChangeLog v1->v3:
- New patch after Marek's review.
---
 drivers/gpio/gpiolib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 230e41562462..a7e3fd512e2d 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4204,6 +4204,8 @@ struct gpio_desc *gpiod_get_from_of_node(struct device_node *node,
 	transitory = flags & OF_GPIO_TRANSITORY;
 
 	ret = gpiod_request(desc, label);
+	if (ret == -EBUSY && (flags & GPIOD_FLAGS_BIT_NONEXCLUSIVE))
+		return desc;
 	if (ret)
 		return ERR_PTR(ret);
 
-- 
2.19.2


  parent reply	other threads:[~2018-12-06 12:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181206124518epcas4p2fd2837b5bc5e0c806e93ce752599e264@epcas4p2.samsung.com>
2018-12-06 12:43 ` [PATCH 00/15 v4] Regulator ena_gpiod fixups Linus Walleij
2018-12-06 12:43   ` [PATCH 01/15 v4] regulator: core: Track dangling GPIO descriptors Linus Walleij
2018-12-06 12:43   ` [PATCH 02/15 v4] regulator: fixed: Let core handle GPIO descriptor Linus Walleij
2018-12-06 12:43   ` [PATCH 03/15 v4] regulator: lm363x: " Linus Walleij
2018-12-06 12:43   ` [PATCH 04/15 v4] regulator: lp8788-ldo: " Linus Walleij
2018-12-06 12:43   ` [PATCH 05/15 v4] regulator: max8952: " Linus Walleij
2018-12-06 12:43   ` [PATCH 06/15 v4] gpio: Export gpiod_get_from_of_node() Linus Walleij
2018-12-06 12:43   ` [PATCH 07/15 v4] regulator: max77686: Let core handle GPIO descriptor Linus Walleij
2018-12-06 12:43   ` Linus Walleij [this message]
2018-12-06 12:43   ` [PATCH 09/15 v4] gpio: devres: Handle nonexclusive GPIOs Linus Walleij
2018-12-06 12:43   ` [PATCH 10/15 v4] gpio: Add devm_gpiod_unhinge() Linus Walleij
2018-12-06 12:43   ` [PATCH 11/15 v4] regulator: max8973: Let core handle GPIO descriptor Linus Walleij
2018-12-06 12:43   ` [PATCH 12/15 v4] regulator: da9211: Hand over GPIO to regulator core Linus Walleij
2018-12-06 12:43   ` [PATCH 13/15 v4] regulator: s5m8767: " Linus Walleij
2018-12-06 12:43   ` [PATCH 14/15 v4] regulator: tps65090: " Linus Walleij
2018-12-06 12:43   ` [PATCH 15/15 v4] regulator: s2mps11: " Linus Walleij
2018-12-06 13:27   ` [PATCH 00/15 v4] Regulator ena_gpiod fixups Marek Szyprowski
2018-12-06 13:49     ` Charles Keepax
2018-12-06 14:41       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206124351.10155-9-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).