leds: gpio: Drop unneeded manual of_node assignment
diff mbox series

Message ID 1544177406-24752-1-git-send-email-krzk@kernel.org
State In Next
Commit b086592e5dcd9cee360f44be801fbcadb24d5c46
Headers show
Series
  • leds: gpio: Drop unneeded manual of_node assignment
Related show

Commit Message

Krzysztof Kozlowski Dec. 7, 2018, 10:10 a.m. UTC
This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
Set of_node for created LED devices") because of_node assignment is
handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
of LED registering function").  Basically the code was overwriting the
of_node with same value.

No functional change expected.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/leds/leds-gpio.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Rafał Miłecki Dec. 7, 2018, 11:24 a.m. UTC | #1
On 2018-12-07 11:10, Krzysztof Kozlowski wrote:
> This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
> Set of_node for created LED devices") because of_node assignment is
> handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
> of LED registering function").  Basically the code was overwriting the
> of_node with same value.
> 
> No functional change expected.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thanks!

Tested-by: Rafał Miłecki <rafal@milecki.pl>
Jacek Anaszewski Dec. 8, 2018, 6:02 p.m. UTC | #2
Hi Krzysztof,

Thank you for the patch.

On 12/7/18 11:10 AM, Krzysztof Kozlowski wrote:
> This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
> Set of_node for created LED devices") because of_node assignment is
> handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
> of LED registering function").  Basically the code was overwriting the
> of_node with same value.
> 
> No functional change expected.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   drivers/leds/leds-gpio.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 45e012093865..998f2ff6914d 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -190,7 +190,6 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
>   			fwnode_handle_put(child);
>   			return ERR_PTR(ret);
>   		}
> -		led_dat->cdev.dev->of_node = np;
>   		priv->num_leds++;
>   	}
>   
> 

Applied.

Patch
diff mbox series

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 45e012093865..998f2ff6914d 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -190,7 +190,6 @@  static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
 			fwnode_handle_put(child);
 			return ERR_PTR(ret);
 		}
-		led_dat->cdev.dev->of_node = np;
 		priv->num_leds++;
 	}